Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2869793002: supersize: Fix --toolprefix="" not being followed (Closed)

Created:
3 years, 7 months ago by agrieve
Modified:
3 years, 7 months ago
Reviewers:
estevenson
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

supersize: Fix --toolprefix="" and normalize cpu metadata --toolprefix="" was triggering autodetection when it shouldn't. x64 ELFs were being reported as "Advanced" rather than "x64" BUG=681694 Review-Url: https://codereview.chromium.org/2869793002 Cr-Commit-Position: refs/heads/master@{#470043} Committed: https://chromium.googlesource.com/chromium/src/+/de4ca3bfeed1d86c3f9b5bbd4d895a4393650a0b

Patch Set 1 #

Patch Set 2 : fix arch detection #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M tools/binary_size/libsupersize/archive.py View 1 2 chunks +13 lines, -3 lines 0 comments Download
M tools/binary_size/libsupersize/paths.py View 1 chunk +4 lines, -2 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Archive_Elf.golden View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/binary_size/libsupersize/testdata/Console.golden View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/binary_size/libsupersize/testdata/Diff_NullDiff.golden View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/binary_size/libsupersize/testdata/FullDescription.golden View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
agrieve
On 2017/05/08 15:01:24, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
3 years, 7 months ago (2017-05-08 15:42:14 UTC) #5
estevenson
On 2017/05/08 15:42:14, agrieve wrote: > On 2017/05/08 15:01:24, commit-bot: I haz the power wrote: ...
3 years, 7 months ago (2017-05-08 16:40:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869793002/20001
3 years, 7 months ago (2017-05-08 17:38:59 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 17:54:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/de4ca3bfeed1d86c3f9b5bbd4d89...

Powered by Google App Engine
This is Rietveld 408576698