Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: tools/binary_size/libsupersize/diff.py

Issue 2869873002: supersize: Sort diffs by default (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/binary_size/libsupersize/console.py ('k') | tools/binary_size/libsupersize/integration_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/libsupersize/diff.py
diff --git a/tools/binary_size/libsupersize/diff.py b/tools/binary_size/libsupersize/diff.py
index c79207df3e8ccc773bdff11f53336772fa26ee10..aa7705457b6c50d4717a7d98bbf205a6a7368938 100644
--- a/tools/binary_size/libsupersize/diff.py
+++ b/tools/binary_size/libsupersize/diff.py
@@ -180,19 +180,12 @@ def _DiffSymbolGroups(before, after):
section_name=after.section_name)
-def Diff(before, after, cluster=True):
- """Diffs two SizeInfo objects. Returns a SizeInfoDiff.
-
- Args:
- cluster: When True, calls SymbolGroup.Cluster() after diffing. This
- generally reduces noise.
- """
+def Diff(before, after):
+ """Diffs two SizeInfo objects. Returns a SizeInfoDiff."""
assert isinstance(before, models.SizeInfo)
assert isinstance(after, models.SizeInfo)
section_sizes = {k: after.section_sizes[k] - v
for k, v in before.section_sizes.iteritems()}
symbol_diff = _DiffSymbolGroups(before.symbols, after.symbols)
- if cluster:
- symbol_diff = symbol_diff.Cluster()
return models.SizeInfoDiff(section_sizes, symbol_diff, before.metadata,
after.metadata)
« no previous file with comments | « tools/binary_size/libsupersize/console.py ('k') | tools/binary_size/libsupersize/integration_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698