Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2866103003: supersize: Fix --tool-prefix autodetection (Closed)

Created:
3 years, 7 months ago by agrieve
Modified:
3 years, 7 months ago
Reviewers:
estevenson
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

supersize: Fix --tool-prefix autodetection Broken by de4ca3bfeed1d86c3f9b5bbd4d895a4393650a0b BUG=681694 Review-Url: https://codereview.chromium.org/2866103003 Cr-Commit-Position: refs/heads/master@{#470341} Committed: https://chromium.googlesource.com/chromium/src/+/adccc21bf05c55215cec58b6d19cb4d39cfa69b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M tools/binary_size/libsupersize/archive.py View 2 chunks +7 lines, -2 lines 0 comments Download
M tools/binary_size/libsupersize/console.py View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
agrieve
On 2017/05/09 14:36:10, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:estevenson@chromium.org 🐚
3 years, 7 months ago (2017-05-09 14:36:22 UTC) #3
estevenson
lgtm
3 years, 7 months ago (2017-05-09 14:59:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866103003/1
3 years, 7 months ago (2017-05-09 15:15:16 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 15:29:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/adccc21bf05c55215cec58b6d19c...

Powered by Google App Engine
This is Rietveld 408576698