Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2866183003: Syntax and coverage checking added to Network Traffic Annotations. (Closed)

Created:
3 years, 7 months ago by Ramin Halavati
Modified:
3 years, 6 months ago
Reviewers:
msramek, battre
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Syntax and coverage checking added to Network Traffic Annotations. Tests added to check if network traffic annotations are syntactically correct and all functions requiring them are properly annotated. BUG=656607 Closing this CL as it was decided to proceed with another approach.

Patch Set 1 #

Patch Set 2 : Prototype ready. #

Patch Set 3 : Partial Update. #

Patch Set 4 : Protobuf build updated. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -54 lines) Patch
M chrome/browser/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/browser/net/traffic_annotation/BUILD.gn View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A chrome/browser/net/traffic_annotation/DEPS View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A chrome/browser/net/traffic_annotation/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/net/traffic_annotation/network_traffic_annotation_checker.h View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A chrome/browser/net/traffic_annotation/network_traffic_annotation_checker.cc View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
M net/traffic_annotation/network_traffic_annotation.h View 1 2 3 chunks +15 lines, -1 line 0 comments Download
M net/url_request/url_fetcher.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/url_request/url_request.h View 1 4 chunks +10 lines, -1 line 0 comments Download
M net/url_request/url_request.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/url_request/url_request_context.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/protobuf/BUILD.gn View 1 2 3 6 chunks +53 lines, -40 lines 0 comments Download
M tools/traffic_annotation/auditor/BUILD.gn View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (11 generated)
Ramin Halavati
3 years, 7 months ago (2017-05-10 09:04:43 UTC) #6
This the first draft for Tests.

Changes in the following files is because we can no more have constexpr at the
beginning of definition. I am checking if it is required or not, but if you
think it is, do you have a suggestion?

chrome/browser/plugins/plugins_resource_service.cc
chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.cc
chrome/browser/safe_browsing/protocol_manager.cc
chrome/browser/sync_file_system/drive_backend/sync_engine.cc
chrome/browser/ui/passwords/account_avatar_fetcher.cc
components/search_engines/template_url_fetcher.cc
content/browser/loader/resource_dispatcher_host_impl.cc
headless/public/util/http_url_fetcher.cc

Powered by Google App Engine
This is Rietveld 408576698