Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Unified Diff: net/url_request/url_request_context.cc

Issue 2866183003: Syntax and coverage checking added to Network Traffic Annotations. (Closed)
Patch Set: Protobuf build updated. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request.cc ('k') | third_party/protobuf/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_context.cc
diff --git a/net/url_request/url_request_context.cc b/net/url_request/url_request_context.cc
index b1f2988f5f89b4887c4c16ea3f21a994888ce628..da1330ea5bcc39c708ef21d64db05b41471fa870 100644
--- a/net/url_request/url_request_context.cc
+++ b/net/url_request/url_request_context.cc
@@ -107,8 +107,7 @@ std::unique_ptr<URLRequest> URLRequestContext::CreateRequest(
const GURL& url,
RequestPriority priority,
URLRequest::Delegate* delegate) const {
- return base::WrapUnique(
- new URLRequest(url, priority, delegate, this, network_delegate_));
+ return CreateRequest(url, priority, delegate, MISSING_TRAFFIC_ANNOTATION);
}
std::unique_ptr<URLRequest> URLRequestContext::CreateRequest(
@@ -116,9 +115,8 @@ std::unique_ptr<URLRequest> URLRequestContext::CreateRequest(
RequestPriority priority,
URLRequest::Delegate* delegate,
NetworkTrafficAnnotationTag traffic_annotation) const {
- // |traffic_annotation| is just a tag that is extracted during static
- // code analysis and can be ignored here.
- return CreateRequest(url, priority, delegate);
+ return base::WrapUnique(new URLRequest(
+ url, priority, delegate, this, network_delegate_, traffic_annotation));
}
void URLRequestContext::set_cookie_store(CookieStore* cookie_store) {
« no previous file with comments | « net/url_request/url_request.cc ('k') | third_party/protobuf/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698