chrome/browser/net/chrome_network_delegate.cc - Issue 2866183003: Syntax and coverage checking added to Network Traffic Annotations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/chrome_network_delegate.cc

Issue 2866183003: Syntax and coverage checking added to Network Traffic Annotations. (Closed)

Patch Set: Protobuf build updated. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/net/chrome_network_delegate.cc

diff --git a/chrome/browser/net/chrome_network_delegate.cc b/chrome/browser/net/chrome_network_delegate.cc

index 55eb0d92c882778756f6320830c2048f87a17bb3..92b69278bba52d6349b5e5714a0cb5422f553988 100644

--- a/chrome/browser/net/chrome_network_delegate.cc

+++ b/chrome/browser/net/chrome_network_delegate.cc

@@ -215,6 +215,10 @@ int ChromeNetworkDelegate::OnBeforeURLRequest(

net::URLRequest* request,

const net::CompletionCallback& callback,

GURL* new_url) {

+#if defined(_DEBUG) || defined(DCHECK_ALWAYS_ON)

+ network_traffic_annotation_checker_.CheckAnnotation(

+ request->traffic_annotation());

+#endif

// TODO(mmenke): Remove ScopedTracker below once crbug.com/456327 is fixed.

tracked_objects::ScopedTracker tracking_profile1(

FROM_HERE_WITH_EXPLICIT_FUNCTION(