Syntax and coverage checking added to Network Traffic Annotations.

third_party/protobuf/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 config("protobuf_config") {
   include_dirs = [ "src" ]
   defines = [
     "GOOGLE_PROTOBUF_NO_RTTI",
     "GOOGLE_PROTOBUF_NO_STATIC_INITIALIZER",
   ]
@@ skipping 23 matching lines @@
     "src",
     "$root_gen_dir/protoc_out",
   ]
 }
 
 protobuf_globals_sources = [
   "src/google/protobuf/globals.cc",
   "src/google/protobuf/stubs/atomicops_internals_x86_gcc.cc",
 ]
 
+text_format_sources = [
+  "src/google/protobuf/any.cc",
+  "src/google/protobuf/any.h",
+  "src/google/protobuf/any.pb.cc",
+  "src/google/protobuf/any.pb.h",
+  "src/google/protobuf/dynamic_message.cc",
+  "src/google/protobuf/dynamic_message.h",
+  "src/google/protobuf/extension_set_heavy.cc",
+  "src/google/protobuf/io/printer.cc",
+  "src/google/protobuf/io/printer.h",
+  "src/google/protobuf/io/strtod.cc",
+  "src/google/protobuf/io/strtod.h",
+  "src/google/protobuf/io/tokenizer.cc",
+  "src/google/protobuf/io/tokenizer.h",
+  "src/google/protobuf/io/zero_copy_stream_impl.cc",
+  "src/google/protobuf/io/zero_copy_stream_impl.h",
+  "src/google/protobuf/descriptor.cc",
+  "src/google/protobuf/descriptor.h",
+  "src/google/protobuf/descriptor.pb.cc",
+  "src/google/protobuf/descriptor.pb.h",
+  "src/google/protobuf/descriptor_database.cc",
+  "src/google/protobuf/descriptor_database.h",
+  "src/google/protobuf/generated_message_reflection.cc",
+  "src/google/protobuf/generated_message_reflection.h",
+  "src/google/protobuf/map_field.cc",
+  "src/google/protobuf/map_field.h",
+  "src/google/protobuf/map_field_inl.h",
+  "src/google/protobuf/message.cc",
+  "src/google/protobuf/message.h",
+  "src/google/protobuf/reflection_ops.cc",
+  "src/google/protobuf/reflection_ops.h",
+  "src/google/protobuf/stubs/substitute.cc",
+  "src/google/protobuf/stubs/substitute.h",
+  "src/google/protobuf/text_format.cc",
+  "src/google/protobuf/text_format.h",
+  "src/google/protobuf/unknown_field_set.cc",
+  "src/google/protobuf/unknown_field_set.h",
+  "src/google/protobuf/wire_format.cc",
+  "src/google/protobuf/wire_format.h",
+]
+
 protobuf_lite_sources = [
   "src/google/protobuf/arena.cc",
   "src/google/protobuf/arena.h",
   "src/google/protobuf/arenastring.cc",
   "src/google/protobuf/arenastring.h",
   "src/google/protobuf/extension_set.cc",
   "src/google/protobuf/extension_set.h",
   "src/google/protobuf/generated_message_util.cc",
   "src/google/protobuf/generated_message_util.h",
   "src/google/protobuf/io/coded_stream.cc",
@@ skipping 63 matching lines @@
   "src/google/protobuf/stubs/strutil.h",
   "src/google/protobuf/stubs/template_util.h",
   "src/google/protobuf/stubs/type_traits.h",
   "src/google/protobuf/stubs/time.cc",
   "src/google/protobuf/stubs/time.h",
   "src/google/protobuf/wire_format_lite.cc",
   "src/google/protobuf/wire_format_lite.h",
   "src/google/protobuf/wire_format_lite_inl.h",
 ]
 
+if (is_debug || dchecks_always_on) {
+  protobuf_lite_sources += text_format_sources
+  text_format_sources = []
+}
+
 protobuf_lite_cflags = []
 if (is_win) {
   protobuf_lite_cflags = [
     "/wd4018",  # signed/unsigned mismatch in comparison
     "/wd4065",  # switch statement contains 'default' but no 'case' labels
     "/wd4146",  # unary minus operator applied to unsigned type
     "/wd4244",  # implicit conversion, possible loss of data
     "/wd4267",  # size_t to int truncation
     "/wd4291",  # no matching operator delete for a placement new.
     "/wd4305",  # double to float truncation
@@ skipping 82 matching lines @@
   # Prevent people from depending on this outside our file.
   visibility = [
     ":*",
 
     # requires descriptors & reflection; testonly.
     "//third_party/libprotobuf-mutator:*",
 
     # The traffic_annotation tool is not part of Chrome itself, and needs to
     # parse human-readable protobufs.
     "//tools/traffic_annotation/*",
+
+    # The traffic_annotation in Chrome is only linked when DCHECKS are on. It
+    # needs to parse human-readable protobufs to check their syntax.
+    "//chrome/browser/net/traffic_annotation/*",
   ]
 
-  sources = protobuf_lite_sources + protobuf_globals_sources + [
-    "src/google/protobuf/any.cc",
-    "src/google/protobuf/any.h",
-    "src/google/protobuf/any.pb.cc",
-    "src/google/protobuf/any.pb.h",
+  sources = protobuf_lite_sources + protobuf_globals_sources +
+            text_format_sources + [
     "src/google/protobuf/api.pb.cc",
     "src/google/protobuf/api.pb.h",
     "src/google/protobuf/compiler/importer.cc",
     "src/google/protobuf/compiler/importer.h",
     "src/google/protobuf/compiler/parser.cc",
     "src/google/protobuf/compiler/parser.h",
-    "src/google/protobuf/descriptor.cc",
-    "src/google/protobuf/descriptor.h",
-    "src/google/protobuf/descriptor.pb.cc",
-    "src/google/protobuf/descriptor.pb.h",
-    "src/google/protobuf/descriptor_database.cc",
-    "src/google/protobuf/descriptor_database.h",
     "src/google/protobuf/duration.pb.cc",
     "src/google/protobuf/duration.pb.h",
-    "src/google/protobuf/dynamic_message.cc",
-    "src/google/protobuf/dynamic_message.h",
     "src/google/protobuf/empty.pb.cc",
     "src/google/protobuf/empty.pb.h",
-    "src/google/protobuf/extension_set_heavy.cc",
     "src/google/protobuf/field_mask.pb.cc",
     "src/google/protobuf/field_mask.pb.h",
     "src/google/protobuf/generated_enum_reflection.h",
     "src/google/protobuf/generated_enum_util.h",
-    "src/google/protobuf/generated_message_reflection.cc",
-    "src/google/protobuf/generated_message_reflection.h",
 
     # gzip_stream.cc pulls in zlib, but it's not actually used by protoc, just
     # by test code, so instead of compiling zlib for the host, let's just
     # exclude this.
     # "src/google/protobuf/io/gzip_stream.cc",
     # "src/google/protobuf/io/gzip_stream.h",
 
-    "src/google/protobuf/io/printer.cc",
-    "src/google/protobuf/io/printer.h",
-    "src/google/protobuf/io/strtod.cc",
-    "src/google/protobuf/io/strtod.h",
-    "src/google/protobuf/io/tokenizer.cc",
-    "src/google/protobuf/io/tokenizer.h",
-    "src/google/protobuf/io/zero_copy_stream_impl.cc",
-    "src/google/protobuf/io/zero_copy_stream_impl.h",
     "src/google/protobuf/map_entry.h",
-    "src/google/protobuf/map_field.cc",
-    "src/google/protobuf/map_field.h",
-    "src/google/protobuf/map_field_inl.h",
-    "src/google/protobuf/message.cc",
-    "src/google/protobuf/message.h",
     "src/google/protobuf/metadata.h",
     "src/google/protobuf/reflection.h",
     "src/google/protobuf/reflection_internal.h",
-    "src/google/protobuf/reflection_ops.cc",
-    "src/google/protobuf/reflection_ops.h",
     "src/google/protobuf/service.cc",
     "src/google/protobuf/service.h",
     "src/google/protobuf/source_context.pb.cc",
     "src/google/protobuf/source_context.pb.h",
     "src/google/protobuf/struct.pb.cc",
     "src/google/protobuf/struct.pb.h",
     "src/google/protobuf/stubs/mathlimits.cc",
     "src/google/protobuf/stubs/mathlimits.h",
     "src/google/protobuf/stubs/mathutil.h",
     "src/google/protobuf/stubs/singleton.h",
-    "src/google/protobuf/stubs/substitute.cc",
-    "src/google/protobuf/stubs/substitute.h",
-    "src/google/protobuf/text_format.cc",
-    "src/google/protobuf/text_format.h",
     "src/google/protobuf/timestamp.pb.cc",
     "src/google/protobuf/timestamp.pb.h",
     "src/google/protobuf/type.pb.cc",
     "src/google/protobuf/type.pb.h",
-    "src/google/protobuf/unknown_field_set.cc",
-    "src/google/protobuf/unknown_field_set.h",
     "src/google/protobuf/util/field_comparator.cc",
     "src/google/protobuf/util/field_comparator.h",
     "src/google/protobuf/util/field_mask_util.cc",
     "src/google/protobuf/util/field_mask_util.h",
     "src/google/protobuf/util/internal/constants.h",
     "src/google/protobuf/util/internal/datapiece.cc",
     "src/google/protobuf/util/internal/datapiece.h",
     "src/google/protobuf/util/internal/default_value_objectwriter.cc",
     "src/google/protobuf/util/internal/default_value_objectwriter.h",
     "src/google/protobuf/util/internal/error_listener.cc",
@@ skipping 26 matching lines @@
     "src/google/protobuf/util/internal/utility.h",
     "src/google/protobuf/util/json_util.cc",
     "src/google/protobuf/util/json_util.h",
     "src/google/protobuf/util/message_differencer.cc",
     "src/google/protobuf/util/message_differencer.h",
     "src/google/protobuf/util/time_util.cc",
     "src/google/protobuf/util/time_util.h",
     "src/google/protobuf/util/type_resolver.h",
     "src/google/protobuf/util/type_resolver_util.cc",
     "src/google/protobuf/util/type_resolver_util.h",
-    "src/google/protobuf/wire_format.cc",
-    "src/google/protobuf/wire_format.h",
     "src/google/protobuf/wrappers.pb.cc",
     "src/google/protobuf/wrappers.pb.h",
   ]
-
+  
   deps = [
     "//build/config/sanitizers:deps",
   ]
 
   configs -= [ "//build/config/compiler:chromium_code" ]
   configs += [
     "//build/config/compiler:no_chromium_code",
 
     # Must be after no_chromium_code for warning flags to be ordered
     # correctly.
@@ skipping 322 matching lines @@
     ":copy_google_protobuf_internal",
     ":copy_six",
   ]
 
   # Targets that depend on this should depend on the copied data files.
   data = get_target_outputs(":copy_google")
   data += get_target_outputs(":copy_six")
   data += get_target_outputs(":copy_google_protobuf")
   data += get_target_outputs(":copy_google_protobuf_internal")
 }