Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: net/url_request/url_fetcher.cc

Issue 2866183003: Syntax and coverage checking added to Network Traffic Annotations. (Closed)
Patch Set: Protobuf build updated. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/traffic_annotation/network_traffic_annotation.h ('k') | net/url_request/url_request.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_fetcher.cc
diff --git a/net/url_request/url_fetcher.cc b/net/url_request/url_fetcher.cc
index 6f020a89d01471c9834dbc570b7216c04a9e31f0..3db83ad5cc08f5c64308603bb76223722a724eff 100644
--- a/net/url_request/url_fetcher.cc
+++ b/net/url_request/url_fetcher.cc
@@ -25,7 +25,7 @@ std::unique_ptr<URLFetcher> URLFetcher::Create(
const GURL& url,
URLFetcher::RequestType request_type,
URLFetcherDelegate* d) {
- return Create(id, url, request_type, d, NO_TRAFFIC_ANNOTATION_YET);
+ return Create(id, url, request_type, d, MISSING_TRAFFIC_ANNOTATION);
}
// static
@@ -45,6 +45,7 @@ std::unique_ptr<URLFetcher> URLFetcher::Create(
URLFetcherDelegate* d,
NetworkTrafficAnnotationTag traffic_annotation) {
URLFetcherFactory* factory = URLFetcherImpl::factory();
+ // TODO(rhalavati@): Add annotation to CreateURLFetcher.
return factory ? factory->CreateURLFetcher(id, url, request_type, d)
: std::unique_ptr<URLFetcher>(new URLFetcherImpl(
url, request_type, d, traffic_annotation));
« no previous file with comments | « net/traffic_annotation/network_traffic_annotation.h ('k') | net/url_request/url_request.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698