Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 286543002: Cleanup CanDownload WebContentsDelegate API (Closed)

Created:
6 years, 7 months ago by Fady Samuel
Modified:
6 years, 7 months ago
Reviewers:
jam, lazyboy
CC:
chromium-reviews, asanka, davidben+watch_chromium.org, cbentzel+watch_chromium.org, gavinp+prer_chromium.org, benjhayden+dwatch_chromium.org, jam, tburkard+watch_chromium.org, dominich+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cleanup CanDownload WebContentsDelegate API It seems we were passing an opaque request ID in WebContentsDelegate::CanDownload that wasn't used anywhere. Instead, for <webview>, we would simply like the URL that generated the download request. This CL simplifies the API and reduces cruft and code complexity BUG=364141, 330264 TBR=sgurun@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270242

Patch Set 1 #

Patch Set 2 : Removed unnecessary include #

Total comments: 2

Patch Set 3 : Fixed Android build hopefully #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -68 lines) Patch
M android_webview/native/aw_web_contents_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_web_contents_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/web_view_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_request_limiter.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/download/download_request_limiter.cc View 7 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/download/download_request_limiter_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/download_resource_throttle.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_resource_throttle.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 2 chunks +1 line, -8 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 2 3 chunks +3 lines, -36 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Fady Samuel
6 years, 7 months ago (2014-05-12 22:59:26 UTC) #1
jam
lgtm
6 years, 7 months ago (2014-05-12 23:06:02 UTC) #2
Fady Samuel
6 years, 7 months ago (2014-05-12 23:23:05 UTC) #3
lazyboy
FYI https://chromiumcodereview.appspot.com/286543002/diff/20001/content/browser/browser_plugin/browser_plugin_guest.cc File content/browser/browser_plugin/browser_plugin_guest.cc (left): https://chromiumcodereview.appspot.com/286543002/diff/20001/content/browser/browser_plugin/browser_plugin_guest.cc#oldcode166 content/browser/browser_plugin/browser_plugin_guest.cc:166: return url_request->url(); Note that this can be different ...
6 years, 7 months ago (2014-05-13 01:33:51 UTC) #4
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 7 months ago (2014-05-13 14:29:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/286543002/20001
6 years, 7 months ago (2014-05-13 14:29:29 UTC) #6
Fady Samuel
https://codereview.chromium.org/286543002/diff/20001/content/browser/browser_plugin/browser_plugin_guest.cc File content/browser/browser_plugin/browser_plugin_guest.cc (left): https://codereview.chromium.org/286543002/diff/20001/content/browser/browser_plugin/browser_plugin_guest.cc#oldcode166 content/browser/browser_plugin/browser_plugin_guest.cc:166: return url_request->url(); On 2014/05/13 01:33:51, lazyboy wrote: > Note ...
6 years, 7 months ago (2014-05-13 14:33:12 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-13 16:43:24 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-13 16:54:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/141942)
6 years, 7 months ago (2014-05-13 16:54:52 UTC) #10
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 7 months ago (2014-05-13 17:40:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/286543002/40001
6 years, 7 months ago (2014-05-13 17:41:24 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 23:25:17 UTC) #13
Message was sent while issue was closed.
Change committed as 270242

Powered by Google App Engine
This is Rietveld 408576698