android_webview/native/aw_web_contents_delegate.cc - Issue 286543002: Cleanup CanDownload WebContentsDelegate API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_web_contents_delegate.cc

Issue 286543002: Cleanup CanDownload WebContentsDelegate API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Android build hopefully Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/native/aw_web_contents_delegate.cc

diff --git a/android_webview/native/aw_web_contents_delegate.cc b/android_webview/native/aw_web_contents_delegate.cc

index c91f6d34b17833035125ead1da6e85a9fa837f56..f9c42b12d204b816d75a241ba409730db8e70bc4 100644

--- a/android_webview/native/aw_web_contents_delegate.cc

+++ b/android_webview/native/aw_web_contents_delegate.cc

@@ -76,7 +76,7 @@ void AwWebContentsDelegate::FindReply(WebContents* web_contents,

void AwWebContentsDelegate::CanDownload(

content::RenderViewHost* source,

- int request_id,

+ const GURL& url,

const std::string& request_method,

const base::Callback<void(bool)>& callback) {

// Android webview intercepts download in its resource dispatcher host