content/public/browser/web_contents_delegate.h - Issue 286543002: Cleanup CanDownload WebContentsDelegate API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/web_contents_delegate.h

Issue 286543002: Cleanup CanDownload WebContentsDelegate API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Android build hopefully Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/browser/web_contents_delegate.h

diff --git a/content/public/browser/web_contents_delegate.h b/content/public/browser/web_contents_delegate.h

index 0193b06af2117c2cc718857c29b3dad943cb3ac8..34a1c07e2fd6d017ecd1a82d70e7e41a31fafe77 100644

--- a/content/public/browser/web_contents_delegate.h

+++ b/content/public/browser/web_contents_delegate.h

@@ -226,7 +226,7 @@ class CONTENT_EXPORT WebContentsDelegate {

// Asks the delegate if the given tab can download.

// Invoking the |callback| synchronously is OK.

virtual void CanDownload(RenderViewHost* render_view_host,

- int request_id,

+ const GURL& url,

const std::string& request_method,

const base::Callback<void(bool)>& callback);