Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 286543002: Cleanup CanDownload WebContentsDelegate API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed Android build hopefully Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_guest.h
diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h
index 7380e362bdfb6c105b7fa4ca4560476d81cce1d1..57f989e6f335b72fb02f4aa30f834cdcdfbab127 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.h
+++ b/content/browser/browser_plugin/browser_plugin_guest.h
@@ -182,7 +182,7 @@ class CONTENT_EXPORT BrowserPluginGuest
bool user_gesture,
bool* was_blocked) OVERRIDE;
virtual void CanDownload(RenderViewHost* render_view_host,
- int request_id,
+ const GURL& url,
const std::string& request_method,
const base::Callback<void(bool)>& callback) OVERRIDE;
virtual void LoadProgressChanged(WebContents* source,
@@ -447,13 +447,6 @@ class CONTENT_EXPORT BrowserPluginGuest
const std::string& name);
void OnUpdateRect(const ViewHostMsg_UpdateRect_Params& params);
- // Requests download permission through embedder JavaScript API after
- // retrieving url information from IO thread.
- void DidRetrieveDownloadURLFromRequestId(
- const std::string& request_method,
- const base::Callback<void(bool)>& callback,
- const GURL& url);
-
// Forwards all messages from the |pending_messages_| queue to the embedder.
void SendQueuedMessages();

Powered by Google App Engine
This is Rietveld 408576698