Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Unified Diff: chrome/browser/download/download_request_limiter.h

Issue 286543002: Cleanup CanDownload WebContentsDelegate API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed Android build hopefully Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/apps/web_view_browsertest.cc ('k') | chrome/browser/download/download_request_limiter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_request_limiter.h
diff --git a/chrome/browser/download/download_request_limiter.h b/chrome/browser/download/download_request_limiter.h
index 83552edecfab1b9991f18fb714a1e39e4a21e830..3a1eb2cd299ecb679d34896cfb2f118e6d4e02ec 100644
--- a/chrome/browser/download/download_request_limiter.h
+++ b/chrome/browser/download/download_request_limiter.h
@@ -189,7 +189,7 @@ class DownloadRequestLimiter
// WARNING: both this call and the callback are invoked on the io thread.
void CanDownloadOnIOThread(int render_process_host_id,
int render_view_id,
- int request_id,
+ const GURL& url,
const std::string& request_method,
const Callback& callback);
@@ -217,21 +217,19 @@ class DownloadRequestLimiter
// tab and invokes CanDownloadImpl.
void CanDownload(int render_process_host_id,
int render_view_id,
- int request_id,
+ const GURL& url,
const std::string& request_method,
const Callback& callback);
// Does the work of updating the download status on the UI thread and
// potentially prompting the user.
void CanDownloadImpl(content::WebContents* originating_contents,
- int request_id,
const std::string& request_method,
const Callback& callback);
// Invoked when decision to download has been made.
void OnCanDownloadDecided(int render_process_host_id,
int render_view_id,
- int request_id,
const std::string& request_method,
const Callback& orig_callback,
bool allow);
« no previous file with comments | « chrome/browser/apps/web_view_browsertest.cc ('k') | chrome/browser/download/download_request_limiter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698