android_webview/native/aw_web_contents_delegate.h - Issue 286543002: Cleanup CanDownload WebContentsDelegate API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_web_contents_delegate.h

Issue 286543002: Cleanup CanDownload WebContentsDelegate API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Android build hopefully Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/native/aw_web_contents_delegate.h

diff --git a/android_webview/native/aw_web_contents_delegate.h b/android_webview/native/aw_web_contents_delegate.h

index dce3fa74331758c490554b35dc35d0cb6d6c5131..1954bc268d66e5aa1d4d6cf19ef76821bad1eccb 100644

--- a/android_webview/native/aw_web_contents_delegate.h

+++ b/android_webview/native/aw_web_contents_delegate.h

@@ -28,7 +28,7 @@ class AwWebContentsDelegate

int active_match_ordinal,

bool final_update) OVERRIDE;

virtual void CanDownload(content::RenderViewHost* source,

- int request_id,

+ const GURL& url,

const std::string& request_method,

const base::Callback<void(bool)>& callback) OVERRIDE;

virtual void RunFileChooser(

« no previous file with comments | « no previous file | android_webview/native/aw_web_contents_delegate.cc » ('j') | no next file with comments »