Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Issue 2863253002: Tighten up a bunch of types in test.dart. (Closed)

Created:
3 years, 7 months ago by Bob Nystrom
Modified:
3 years, 7 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tighten up a bunch of types in test.dart. This doesn't get rid of all implicit dynamic and casts, but it covers many of them. Also did some minor modernization when I noticed it: - Using "var" for local variables where inference does the right thing. - camelCase for variable names. - More collection literals. There are (or should be!) zero behavioral changes. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/e0180925f67507db9f60cb3bca030f3f03521707

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into types-for-test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -321 lines) Patch
M tools/testing/dart/android.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M tools/testing/dart/browser_controller.dart View 1 17 chunks +38 lines, -29 lines 0 comments Download
M tools/testing/dart/co19_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 18 chunks +55 lines, -63 lines 0 comments Download
M tools/testing/dart/dependency_graph.dart View 2 chunks +9 lines, -6 lines 0 comments Download
M tools/testing/dart/drt_updater.dart View 2 chunks +3 lines, -1 line 0 comments Download
M tools/testing/dart/http_server.dart View 6 chunks +10 lines, -9 lines 0 comments Download
M tools/testing/dart/multitest.dart View 4 chunks +20 lines, -22 lines 0 comments Download
M tools/testing/dart/package_testing_support.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/testing/dart/path.dart View 4 chunks +7 lines, -7 lines 0 comments Download
M tools/testing/dart/record_and_replay.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/testing/dart/status_expression.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/status_file_parser.dart View 9 chunks +28 lines, -24 lines 0 comments Download
M tools/testing/dart/status_reporter.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M tools/testing/dart/test_configurations.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/testing/dart/test_options.dart View 6 chunks +8 lines, -9 lines 0 comments Download
M tools/testing/dart/test_progress.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_runner.dart View 1 33 chunks +98 lines, -64 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 22 chunks +45 lines, -59 lines 0 comments Download
M tools/testing/dart/utils.dart View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Bob Nystrom
3 years, 7 months ago (2017-05-05 22:02:35 UTC) #2
Bob Nystrom
Friendly ping!
3 years, 7 months ago (2017-05-12 16:00:05 UTC) #3
Bill Hesse
lgtm
3 years, 7 months ago (2017-05-15 15:08:51 UTC) #4
Bob Nystrom
3 years, 7 months ago (2017-05-15 22:26:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e0180925f67507db9f60cb3bca030f3f03521707 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698