Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: tools/testing/dart/test_configurations.dart

Issue 2863253002: Tighten up a bunch of types in test.dart. (Closed)
Patch Set: Merge branch 'master' into types-for-test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/testing/dart/status_reporter.dart ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test_configurations; 5 library test_configurations;
6 6
7 import "dart:async"; 7 import "dart:async";
8 import 'dart:convert'; 8 import 'dart:convert';
9 import 'dart:io'; 9 import 'dart:io';
10 import "dart:math" as math; 10 import "dart:math" as math;
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 } 95 }
96 96
97 DebugLogger.init( 97 DebugLogger.init(
98 firstConf['write_debug_log'] ? TestUtils.debugLogFilePath : null, 98 firstConf['write_debug_log'] ? TestUtils.debugLogFilePath : null,
99 append: firstConf['append_logs']); 99 append: firstConf['append_logs']);
100 100
101 // Print the configurations being run by this execution of 101 // Print the configurations being run by this execution of
102 // test.dart. However, don't do it if the silent progress indicator 102 // test.dart. However, don't do it if the silent progress indicator
103 // is used. This is only needed because of the junit tests. 103 // is used. This is only needed because of the junit tests.
104 if (progressIndicator != 'silent') { 104 if (progressIndicator != 'silent') {
105 List output_words = configurations.length > 1 105 var outputWords = configurations.length > 1
106 ? ['Test configurations:'] 106 ? ['Test configurations:']
107 : ['Test configuration:']; 107 : ['Test configuration:'];
108 for (Map conf in configurations) { 108 for (Map conf in configurations) {
109 List settings = ['compiler', 'runtime', 'mode', 'arch'] 109 List settings = ['compiler', 'runtime', 'mode', 'arch']
110 .map((name) => conf[name]) 110 .map((name) => conf[name])
111 .toList(); 111 .toList();
112 if (conf['checked']) settings.add('checked'); 112 if (conf['checked']) settings.add('checked');
113 if (conf['strong']) settings.add('strong'); 113 if (conf['strong']) settings.add('strong');
114 output_words.add(settings.join('_')); 114 outputWords.add(settings.join('_'));
115 } 115 }
116 print(output_words.join(' ')); 116 print(outputWords.join(' '));
117 } 117 }
118 118
119 var runningBrowserTests = configurations.any((config) { 119 var runningBrowserTests = configurations.any((config) {
120 return TestUtils.isBrowserRuntime(config['runtime']); 120 return TestUtils.isBrowserRuntime(config['runtime']);
121 }); 121 });
122 122
123 List<Future> serverFutures = []; 123 List<Future> serverFutures = [];
124 var testSuites = new List<TestSuite>(); 124 var testSuites = <TestSuite>[];
125 var maxBrowserProcesses = maxProcesses; 125 var maxBrowserProcesses = maxProcesses;
126 if (configurations.length > 1 && 126 if (configurations.length > 1 &&
127 (configurations[0]['test_server_port'] != 0 || 127 (configurations[0]['test_server_port'] != 0 ||
128 configurations[0]['test_server_cross_origin_port'] != 0)) { 128 configurations[0]['test_server_cross_origin_port'] != 0)) {
129 print("If the http server ports are specified, only one configuration" 129 print("If the http server ports are specified, only one configuration"
130 " may be run at a time"); 130 " may be run at a time");
131 exit(1); 131 exit(1);
132 } 132 }
133 for (var conf in configurations) { 133 for (var conf in configurations) {
134 Map<String, RegExp> selectors = conf['selectors']; 134 Map<String, RegExp> selectors = conf['selectors'];
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
307 maxBrowserProcesses, 307 maxBrowserProcesses,
308 startTime, 308 startTime,
309 testSuites, 309 testSuites,
310 eventListener, 310 eventListener,
311 allTestsFinished, 311 allTestsFinished,
312 verbose, 312 verbose,
313 recordingPath, 313 recordingPath,
314 recordingOutputPath, 314 recordingOutputPath,
315 adbDevicePool); 315 adbDevicePool);
316 } 316 }
OLDNEW
« no previous file with comments | « tools/testing/dart/status_reporter.dart ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698