Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: tools/testing/dart/status_reporter.dart

Issue 2863253002: Tighten up a bunch of types in test.dart. (Closed)
Patch Set: Merge branch 'master' into types-for-test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/status_file_parser.dart ('k') | tools/testing/dart/test_configurations.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/status_reporter.dart
diff --git a/tools/testing/dart/status_reporter.dart b/tools/testing/dart/status_reporter.dart
index 37f66aecb3036990ce9c22f0b0eb318d3625f1b2..734fb262da02fc32668cdb6369e5fe3a328cec20 100644
--- a/tools/testing/dart/status_reporter.dart
+++ b/tools/testing/dart/status_reporter.dart
@@ -5,7 +5,7 @@
import 'dart:io';
import 'dart:convert';
-List<Map> LINUX_COMBINATIONS = [
+final LINUX_COMBINATIONS = [
{
'runtimes': ['none'],
'modes': ['release'],
@@ -38,7 +38,7 @@ List<Map> LINUX_COMBINATIONS = [
},
];
-List<Map> MACOS_COMBINATIONS = [
+final MACOS_COMBINATIONS = [
{
'runtimes': ['vm'],
'modes': ['debug', 'release'],
@@ -59,7 +59,7 @@ List<Map> MACOS_COMBINATIONS = [
},
];
-List<Map> WINDOWS_COMBINATIONS = [
+final WINDOWS_COMBINATIONS = [
{
'runtimes': ['vm'],
'modes': ['debug', 'release'],
@@ -80,7 +80,7 @@ List<Map> WINDOWS_COMBINATIONS = [
},
];
-Map<String, List<Map>> COMBINATIONS = {
+final COMBINATIONS = {
'linux': LINUX_COMBINATIONS,
'windows': WINDOWS_COMBINATIONS,
'macos': MACOS_COMBINATIONS
@@ -193,7 +193,7 @@ void main(List<String> args) {
var totalIndex = result.stdout.indexOf('JSON:');
var report = result.stdout.substring(totalIndex + 5);
- var map = JSON.decode(report) as Map;
+ var map = JSON.decode(report) as Map<String, int>;
if (keys == null) {
keys = map.keys.toList();
« no previous file with comments | « tools/testing/dart/status_file_parser.dart ('k') | tools/testing/dart/test_configurations.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698