Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: tools/testing/dart/test_configurations.dart

Issue 2863253002: Tighten up a bunch of types in test.dart. (Closed)
Patch Set: Merge branch 'master' into types-for-test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/status_reporter.dart ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_configurations.dart
diff --git a/tools/testing/dart/test_configurations.dart b/tools/testing/dart/test_configurations.dart
index e147a21cec8f333aa13b64de5c06e7513df127c0..7e690fe212a1b81fa9910b2e5d8633bc99107c36 100644
--- a/tools/testing/dart/test_configurations.dart
+++ b/tools/testing/dart/test_configurations.dart
@@ -102,7 +102,7 @@ Future testConfigurations(List<Map> configurations) async {
// test.dart. However, don't do it if the silent progress indicator
// is used. This is only needed because of the junit tests.
if (progressIndicator != 'silent') {
- List output_words = configurations.length > 1
+ var outputWords = configurations.length > 1
? ['Test configurations:']
: ['Test configuration:'];
for (Map conf in configurations) {
@@ -111,9 +111,9 @@ Future testConfigurations(List<Map> configurations) async {
.toList();
if (conf['checked']) settings.add('checked');
if (conf['strong']) settings.add('strong');
- output_words.add(settings.join('_'));
+ outputWords.add(settings.join('_'));
}
- print(output_words.join(' '));
+ print(outputWords.join(' '));
}
var runningBrowserTests = configurations.any((config) {
@@ -121,7 +121,7 @@ Future testConfigurations(List<Map> configurations) async {
});
List<Future> serverFutures = [];
- var testSuites = new List<TestSuite>();
+ var testSuites = <TestSuite>[];
var maxBrowserProcesses = maxProcesses;
if (configurations.length > 1 &&
(configurations[0]['test_server_port'] != 0 ||
« no previous file with comments | « tools/testing/dart/status_reporter.dart ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698