Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: tools/testing/dart/utils.dart

Issue 2863253002: Tighten up a bunch of types in test.dart. (Closed)
Patch Set: Merge branch 'master' into types-for-test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_suite.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/utils.dart
diff --git a/tools/testing/dart/utils.dart b/tools/testing/dart/utils.dart
index a65c4b48ed34107734004441f5cb3e5479aaaee2..b80f4bcd0504339634ef61eb566c93648ef7d6c9 100644
--- a/tools/testing/dart/utils.dart
+++ b/tools/testing/dart/utils.dart
@@ -24,7 +24,7 @@ class DebugLogger {
/**
* If [path] was null, the DebugLogger will write messages to stdout.
*/
- static init(Path path, {append: false}) {
+ static void init(Path path, {bool append: false}) {
if (path != null) {
var mode = append ? FileMode.APPEND : FileMode.WRITE;
_sink = new File(path.toNativePath()).openWrite(mode: mode);
@@ -180,7 +180,7 @@ String decodeUtf8(List<int> bytes) {
class Locations {
static String getBrowserLocation(
- String browserName, Map globalConfiguration) {
+ String browserName, Map<String, String> globalConfiguration) {
var location = globalConfiguration[browserName];
if (location != null && location != '') {
return location;
@@ -306,7 +306,8 @@ class UniqueObject {
final int _hashCode;
int get hashCode => _hashCode;
- operator ==(other) => other is UniqueObject && _hashCode == other._hashCode;
+ operator ==(Object other) =>
+ other is UniqueObject && _hashCode == other._hashCode;
UniqueObject() : _hashCode = ++_nextId;
}
« no previous file with comments | « tools/testing/dart/test_suite.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698