Tighten up a bunch of types in test.dart.

tools/testing/dart/utils.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library utils;
 
 import 'dart:io';
 import 'dart:convert';
 
 import 'path.dart';
 
 // This is the maximum time we expect stdout/stderr of subprocesses to deliver
 // data after we've got the exitCode.
 const Duration MAX_STDIO_DELAY = const Duration(seconds: 30);
 
 String MAX_STDIO_DELAY_PASSED_MESSAGE =
     """Not waiting for stdout/stderr from subprocess anymore
  ($MAX_STDIO_DELAY passed). Please note that this could be an indicator
  that there is a hanging process which we were unable to kill.""";
 
 class DebugLogger {
   static IOSink _sink;
 
   /**
    * If [path] was null, the DebugLogger will write messages to stdout.
    */
-  static init(Path path, {append: false}) {
+  static void init(Path path, {bool append: false}) {
     if (path != null) {
       var mode = append ? FileMode.APPEND : FileMode.WRITE;
       _sink = new File(path.toNativePath()).openWrite(mode: mode);
     }
   }
 
   static void close() {
     if (_sink != null) {
       _sink.close();
       _sink = null;
@@ skipping 135 matching lines @@
 
 // TODO(kustermann,ricow): As soon we have a debug log we should log
 // invalid utf8-encoded input to the log.
 // Currently invalid bytes will be replaced by a replacement character.
 String decodeUtf8(List<int> bytes) {
   return UTF8.decode(bytes, allowMalformed: true);
 }
 
 class Locations {
   static String getBrowserLocation(
-      String browserName, Map globalConfiguration) {
+      String browserName, Map<String, String> globalConfiguration) {
     var location = globalConfiguration[browserName];
     if (location != null && location != '') {
       return location;
     }
     var browserLocations = {
       'firefox': const {
         'windows': 'C:\\Program Files (x86)\\Mozilla Firefox\\firefox.exe',
         'linux': 'firefox',
         'macos': '/Applications/Firefox.app/Contents/MacOS/firefox'
       },
@@ skipping 105 matching lines @@
     throw new Exception("Can't compare two non json-like objects "
         "(a: ${a.runtimeType}, b: ${b.runtimeType})");
   }
 }
 
 class UniqueObject {
   static int _nextId = 1;
   final int _hashCode;
 
   int get hashCode => _hashCode;
-  operator ==(other) => other is UniqueObject && _hashCode == other._hashCode;
+  operator ==(Object other) =>
+      other is UniqueObject && _hashCode == other._hashCode;
 
   UniqueObject() : _hashCode = ++_nextId;
 }