Let table row and section's self visual overflow cover whole collapsed borders

Let table row and section's self visual overflow cover whole collapsed borders

This ensures correct raster invalidation when row or section's border
style changes and fix under-invalidation.

The new logic in LayoutTableRow::ComputeOverflow() will be also useful when we
let row be the display item client of collapsed borders (crbug.com/663208).
At that time the new logic in LayoutTableSection::ComputeOverflowFromDescendants()
will be replaced by paint invalidation of contained rows on section border
style change.

BUG=626748
Review-Url: https://codereview.chromium.org/2861373003
Cr-Commit-Position: refs/heads/master@{#470268}
Committed: https://chromium.googlesource.com/chromium/src/+/dba4d1702934a03d833c91f2c025faf2106b9c76

[Xianzhu, 2017-05-08 01:48:41]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 01:49:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 03:00:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 03:00:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2017-05-08 05:42:30]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 05:42:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 07:46:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 07:46:08]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2017-05-08 16:40:22]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 16:41:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-05-08 16:47:01]

Description was changed from

==========
Let table row and section's self visual overflow cover whole collapsed borders

BUG=626748
==========

to

==========
Let table row and section's self visual overflow cover whole collapsed borders

This ensures correct raster invalidation when row or section's border
style changes and fix under-invalidation.

The new logic in LayoutTableRow::ComputeOverflow() will be also useful when we
let row be the display item client of collapsed borders (crbug.com/663208).
At that time the new logic in
LayoutTableSection::ComputeOverflowFromDescendants()
will be replaced by paint invalidation of contained rows on section border
style change.

BUG=626748
==========

[Xianzhu, 2017-05-08 16:50:05]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[Xianzhu, 2017-05-08 16:50:19]

wangxianzhu@chromium.org changed reviewers:
+ robhogan@gmail.com, wkorman@chromium.org

[commit-bot: I haz the power, 2017-05-08 16:50:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 17:08:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 17:08:24]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[wkorman, 2017-05-08 17:51:24]

lgtm

https://codereview.chromium.org/2861373003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutTableCellTest.cpp (right):

https://codereview.chromium.org/2861373003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutTableCellTest.cpp:257:
TEST_F(LayoutTableCellTest, LocalVisualRectWithCollapedBorders) {
Collaped -> Collapsed

https://codereview.chromium.org/2861373003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutTableSection.cpp (right):

https://codereview.chromium.org/2861373003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutTableSection.cpp:1316: // We need to
set m_forcesSlowPaintPath only if there is a least one
a least -> at least

https://codereview.chromium.org/2861373003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutTableSection.cpp:1317: //
overflowing cells as the hit testing code rely on this information.
cells -> cell, rely -> relies

https://codereview.chromium.org/2861373003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutTableSectionTest.cpp (right):

https://codereview.chromium.org/2861373003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutTableSectionTest.cpp:214:
TEST_F(LayoutTableSectionTest, VisualOverflowWithCollapedBorders) {
Collaped -> Collapsed

[Xianzhu, 2017-05-08 18:35:16]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 18:35:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 18:42:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 18:42:09]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Xianzhu, 2017-05-09 03:55:43]

https://codereview.chromium.org/2861373003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutTableCellTest.cpp (right):

https://codereview.chromium.org/2861373003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutTableCellTest.cpp:257:
TEST_F(LayoutTableCellTest, LocalVisualRectWithCollapedBorders) {
On 2017/05/08 17:51:23, wkorman wrote:
> Collaped -> Collapsed

Done.

https://codereview.chromium.org/2861373003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutTableSection.cpp (right):

https://codereview.chromium.org/2861373003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutTableSection.cpp:1316: // We need to
set m_forcesSlowPaintPath only if there is a least one
On 2017/05/08 17:51:23, wkorman wrote:
> a least -> at least

Done.

https://codereview.chromium.org/2861373003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutTableSection.cpp:1316: // We need to
set m_forcesSlowPaintPath only if there is a least one
On 2017/05/08 17:51:23, wkorman wrote:
> a least -> at least

Done.

https://codereview.chromium.org/2861373003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutTableSection.cpp:1317: //
overflowing cells as the hit testing code rely on this information.
On 2017/05/08 17:51:23, wkorman wrote:
> cells -> cell, rely -> relies

Done.

https://codereview.chromium.org/2861373003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutTableSectionTest.cpp (right):

https://codereview.chromium.org/2861373003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutTableSectionTest.cpp:214:
TEST_F(LayoutTableSectionTest, VisualOverflowWithCollapedBorders) {
On 2017/05/08 17:51:23, wkorman wrote:
> Collaped -> Collapsed

Done.

[Xianzhu, 2017-05-09 05:23:50]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 05:24:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-05-09 05:46:37]

The CQ bit was unchecked by wangxianzhu@chromium.org

[Xianzhu, 2017-05-09 05:46:37]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-05-09 05:46:38]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2861373003/#ps130001
(title: "rebaseline-cl")

[commit-bot: I haz the power, 2017-05-09 05:46:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 09:00:14]

CQ is committing da patch.

Bot data: {"patchset_id": 130001, "attempt_start_ts": 1494308797896060,
"parent_rev": "cffa5eef397958bc2fbc0500af130ebecd07a8c9", "commit_rev":
"dba4d1702934a03d833c91f2c025faf2106b9c76"}

[commit-bot: I haz the power, 2017-05-09 09:00:30]

Description was changed from

==========
Let table row and section's self visual overflow cover whole collapsed borders

This ensures correct raster invalidation when row or section's border
style changes and fix under-invalidation.

The new logic in LayoutTableRow::ComputeOverflow() will be also useful when we
let row be the display item client of collapsed borders (crbug.com/663208).
At that time the new logic in
LayoutTableSection::ComputeOverflowFromDescendants()
will be replaced by paint invalidation of contained rows on section border
style change.

BUG=626748
==========

to

==========
Let table row and section's self visual overflow cover whole collapsed borders

This ensures correct raster invalidation when row or section's border
style changes and fix under-invalidation.

The new logic in LayoutTableRow::ComputeOverflow() will be also useful when we
let row be the display item client of collapsed borders (crbug.com/663208).
At that time the new logic in
LayoutTableSection::ComputeOverflowFromDescendants()
will be replaced by paint invalidation of contained rows on section border
style change.

BUG=626748

Review-Url: https://codereview.chromium.org/2861373003
Cr-Commit-Position: refs/heads/master@{#470268}
Committed:
https://chromium.googlesource.com/chromium/src/+/dba4d1702934a03d833c91f2c025...
==========

[commit-bot: I haz the power, 2017-05-09 09:00:31]

Committed patchset #8 (id:130001) as
https://chromium.googlesource.com/chromium/src/+/dba4d1702934a03d833c91f2c025...