Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTable.cpp

Issue 2861373003: Let table row and section's self visual overflow cover whole collapsed borders (Closed)
Patch Set: rebaseline-cl Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 9 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
10 * 10 *
(...skipping 521 matching lines...) Expand 10 before | Expand all | Expand 10 after
532 // FIXME: We should walk through the items in the tree in tree order to do the 532 // FIXME: We should walk through the items in the tree in tree order to do the
533 // layout here instead of walking through individual parts of the tree. 533 // layout here instead of walking through individual parts of the tree.
534 // crbug.com/442737 534 // crbug.com/442737
535 for (auto& caption : captions_) 535 for (auto& caption : captions_)
536 caption->LayoutIfNeeded(); 536 caption->LayoutIfNeeded();
537 537
538 for (LayoutTableSection* section = TopSection(); section; 538 for (LayoutTableSection* section = TopSection(); section;
539 section = SectionBelow(section)) { 539 section = SectionBelow(section)) {
540 section->LayoutIfNeeded(); 540 section->LayoutIfNeeded();
541 section->LayoutRows(); 541 section->LayoutRows();
542 section->ComputeOverflowFromCells(); 542 section->ComputeOverflowFromDescendants();
543 section->UpdateAfterLayout(); 543 section->UpdateAfterLayout();
544 section->AddVisualEffectOverflow(); 544 section->AddVisualEffectOverflow();
545 } 545 }
546 } 546 }
547 547
548 bool LayoutTable::RecalcChildOverflowAfterStyleChange() { 548 bool LayoutTable::RecalcChildOverflowAfterStyleChange() {
549 DCHECK(ChildNeedsOverflowRecalcAfterStyleChange()); 549 DCHECK(ChildNeedsOverflowRecalcAfterStyleChange());
550 ClearChildNeedsOverflowRecalcAfterStyleChange(); 550 ClearChildNeedsOverflowRecalcAfterStyleChange();
551 551
552 // If the table sections we keep pointers to have gone away then the table 552 // If the table sections we keep pointers to have gone away then the table
(...skipping 1207 matching lines...) Expand 10 before | Expand all | Expand 10 after
1760 } 1760 }
1761 1761
1762 LayoutUnit LayoutTable::PaddingRight() const { 1762 LayoutUnit LayoutTable::PaddingRight() const {
1763 if (ShouldCollapseBorders()) 1763 if (ShouldCollapseBorders())
1764 return LayoutUnit(); 1764 return LayoutUnit();
1765 1765
1766 return LayoutBlock::PaddingRight(); 1766 return LayoutBlock::PaddingRight();
1767 } 1767 }
1768 1768
1769 } // namespace blink 1769 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698