Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2863933003: Remove the parameter of LayoutBox::XXXOverflowRectForPropagation() (Closed)

Created:
3 years, 7 months ago by Xianzhu
Modified:
3 years, 7 months ago
Reviewers:
eae
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the parameter of LayoutBox::XXXOverflowRectForPropagation() The parameter was not documented in the header file, but was required to be the caller's (parent's) style. Remove the parameter to simplify callers. Also extract LayoutBox::RectForOverflowPropagation() for common code. I created this CL because I need LayoutBox::RectForOverflowPropagation() in another CL. R=eae@chromium.org Review-Url: https://codereview.chromium.org/2863933003 . Cr-Commit-Position: refs/heads/master@{#470239} Committed: https://chromium.googlesource.com/chromium/src/+/bbfb3316d1d216a98ca569445e304aa6e6f4e6d4

Patch Set 1 #

Patch Set 2 : Remove the parameter of LayoutBox::XXXOverflowRectForPropagation() #

Patch Set 3 : Rebase #

Patch Set 4 : - #

Patch Set 5 : - #

Patch Set 6 : - #

Patch Set 7 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -59 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 2 3 4 5 1 chunk +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 2 3 4 5 4 chunks +21 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp View 1 1 chunk +50 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableRow.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LineLayoutBox.h View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 30 (26 generated)
Xianzhu
3 years, 7 months ago (2017-05-08 16:22:52 UTC) #17
eae
Thank you, LGTM!
3 years, 7 months ago (2017-05-08 16:24:04 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863933003/110001
3 years, 7 months ago (2017-05-09 03:52:32 UTC) #28
Xianzhu
3 years, 7 months ago (2017-05-09 05:45:49 UTC) #30
Message was sent while issue was closed.
Committed patchset #7 (id:110001) manually as
bbfb3316d1d216a98ca569445e304aa6e6f4e6d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698