Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableCell.h

Issue 2861373003: Let table row and section's self visual overflow cover whole collapsed borders (Closed)
Patch Set: rebaseline-cl Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTableCell.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableCell.h b/third_party/WebKit/Source/core/layout/LayoutTableCell.h
index f4208542fed419266ece076861f544d6afa89af6..6f4ca949e5debffb98e1b88b8ee66aa0a89f5ba3 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableCell.h
+++ b/third_party/WebKit/Source/core/layout/LayoutTableCell.h
@@ -317,17 +317,21 @@ class CORE_EXPORT LayoutTableCell final : public LayoutBlockFlow {
String DebugName() const;
LayoutRect VisualRect() const;
+ LayoutRect LocalVisualRect() const { return local_visual_rect_; }
+ void SetLocalVisualRect(const LayoutRect& r) { local_visual_rect_ = r; }
+
private:
const LayoutTableCell& layout_table_cell_;
CollapsedBorderValue start_border_;
CollapsedBorderValue end_border_;
CollapsedBorderValue before_border_;
CollapsedBorderValue after_border_;
+ LayoutRect local_visual_rect_;
};
bool UsesCompositedCellDisplayItemClients() const;
const CollapsedBorderValues* GetCollapsedBorderValues() const {
- DCHECK(collapsed_border_values_valid_);
+ UpdateCollapsedBorderValues();
return collapsed_border_values_.get();
}
void InvalidateCollapsedBorderValues() {
@@ -371,6 +375,9 @@ class CORE_EXPORT LayoutTableCell final : public LayoutBlockFlow {
void PaintMask(const PaintInfo&, const LayoutPoint&) const override;
LayoutSize OffsetFromContainer(const LayoutObject*) const override;
+
+ void ComputeOverflow(LayoutUnit old_client_after_edge,
+ bool recompute_floats = false) override;
LayoutRect LocalVisualRect() const override;
LayoutUnit CollapsedBorderHalfLeft(bool outer) const;
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTable.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutTableCell.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698