Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTableCell.h

Issue 2861373003: Let table row and section's self visual overflow cover whole collapsed borders (Closed)
Patch Set: rebaseline-cl Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2009, 2013 Apple Inc. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2009, 2013 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 const CollapsedBorderValue& EndBorder() const { return end_border_; } 310 const CollapsedBorderValue& EndBorder() const { return end_border_; }
311 const CollapsedBorderValue& BeforeBorder() const { return before_border_; } 311 const CollapsedBorderValue& BeforeBorder() const { return before_border_; }
312 const CollapsedBorderValue& AfterBorder() const { return after_border_; } 312 const CollapsedBorderValue& AfterBorder() const { return after_border_; }
313 313
314 void SetCollapsedBorderValues(const CollapsedBorderValues& other); 314 void SetCollapsedBorderValues(const CollapsedBorderValues& other);
315 315
316 // DisplayItemClient methods. 316 // DisplayItemClient methods.
317 String DebugName() const; 317 String DebugName() const;
318 LayoutRect VisualRect() const; 318 LayoutRect VisualRect() const;
319 319
320 LayoutRect LocalVisualRect() const { return local_visual_rect_; }
321 void SetLocalVisualRect(const LayoutRect& r) { local_visual_rect_ = r; }
322
320 private: 323 private:
321 const LayoutTableCell& layout_table_cell_; 324 const LayoutTableCell& layout_table_cell_;
322 CollapsedBorderValue start_border_; 325 CollapsedBorderValue start_border_;
323 CollapsedBorderValue end_border_; 326 CollapsedBorderValue end_border_;
324 CollapsedBorderValue before_border_; 327 CollapsedBorderValue before_border_;
325 CollapsedBorderValue after_border_; 328 CollapsedBorderValue after_border_;
329 LayoutRect local_visual_rect_;
326 }; 330 };
327 331
328 bool UsesCompositedCellDisplayItemClients() const; 332 bool UsesCompositedCellDisplayItemClients() const;
329 const CollapsedBorderValues* GetCollapsedBorderValues() const { 333 const CollapsedBorderValues* GetCollapsedBorderValues() const {
330 DCHECK(collapsed_border_values_valid_); 334 UpdateCollapsedBorderValues();
331 return collapsed_border_values_.get(); 335 return collapsed_border_values_.get();
332 } 336 }
333 void InvalidateCollapsedBorderValues() { 337 void InvalidateCollapsedBorderValues() {
334 collapsed_border_values_valid_ = false; 338 collapsed_border_values_valid_ = false;
335 } 339 }
336 340
337 LayoutRect DebugRect() const override; 341 LayoutRect DebugRect() const override;
338 342
339 void AdjustChildDebugRect(LayoutRect&) const override; 343 void AdjustChildDebugRect(LayoutRect&) const override;
340 344
(...skipping 23 matching lines...) Expand all
364 368
365 void WillBeRemovedFromTree() override; 369 void WillBeRemovedFromTree() override;
366 370
367 void UpdateLogicalWidth() override; 371 void UpdateLogicalWidth() override;
368 372
369 void PaintBoxDecorationBackground(const PaintInfo&, 373 void PaintBoxDecorationBackground(const PaintInfo&,
370 const LayoutPoint&) const override; 374 const LayoutPoint&) const override;
371 void PaintMask(const PaintInfo&, const LayoutPoint&) const override; 375 void PaintMask(const PaintInfo&, const LayoutPoint&) const override;
372 376
373 LayoutSize OffsetFromContainer(const LayoutObject*) const override; 377 LayoutSize OffsetFromContainer(const LayoutObject*) const override;
378
379 void ComputeOverflow(LayoutUnit old_client_after_edge,
380 bool recompute_floats = false) override;
374 LayoutRect LocalVisualRect() const override; 381 LayoutRect LocalVisualRect() const override;
375 382
376 LayoutUnit CollapsedBorderHalfLeft(bool outer) const; 383 LayoutUnit CollapsedBorderHalfLeft(bool outer) const;
377 LayoutUnit CollapsedBorderHalfRight(bool outer) const; 384 LayoutUnit CollapsedBorderHalfRight(bool outer) const;
378 LayoutUnit CollapsedBorderHalfTop(bool outer) const; 385 LayoutUnit CollapsedBorderHalfTop(bool outer) const;
379 LayoutUnit CollapsedBorderHalfBottom(bool outer) const; 386 LayoutUnit CollapsedBorderHalfBottom(bool outer) const;
380 387
381 LayoutUnit CollapsedBorderHalfStart(bool outer) const; 388 LayoutUnit CollapsedBorderHalfStart(bool outer) const;
382 LayoutUnit CollapsedBorderHalfEnd(bool outer) const; 389 LayoutUnit CollapsedBorderHalfEnd(bool outer) const;
383 LayoutUnit CollapsedBorderHalfBefore(bool outer) const; 390 LayoutUnit CollapsedBorderHalfBefore(bool outer) const;
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
471 return ToLayoutTableCell(FirstChild()); 478 return ToLayoutTableCell(FirstChild());
472 } 479 }
473 480
474 inline LayoutTableCell* LayoutTableRow::LastCell() const { 481 inline LayoutTableCell* LayoutTableRow::LastCell() const {
475 return ToLayoutTableCell(LastChild()); 482 return ToLayoutTableCell(LastChild());
476 } 483 }
477 484
478 } // namespace blink 485 } // namespace blink
479 486
480 #endif // LayoutTableCell_h 487 #endif // LayoutTableCell_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTable.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutTableCell.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698