Rename Resource::GetError() to FinishAsError()

Rename Resource::GetError() to FinishAsError()

In Blink Renaming, Resource::error() was incorrectly renamed to GetError().
This CL re-renames it to FinishAsError().

This CL doesn't rename it to Error() because Error() looks like the getter of
|Resource::error_|.

BUG=675877
Review-Url: https://codereview.chromium.org/2855883004
Cr-Commit-Position: refs/heads/master@{#469487}
Committed: https://chromium.googlesource.com/chromium/src/+/270315a23344b1ca5a714d1e4d1f76fbbab43538

[hiroshige, 2017-05-02 22:35:14]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 22:35:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-05-02 22:36:21]

hiroshige@chromium.org changed reviewers:
+ japhet@chromium.org

[hiroshige, 2017-05-02 22:36:21]

PTAL.

[hiroshige, 2017-05-02 22:36:28]

Description was changed from

==========
Rename Resource::GetError() to FinishAsError()

In Blink Renaming, Resource::error() was incorrectly renamed to GetError().
This CL re-renames it to FinishAsError().

This CL doesn't rename it to Error() because Error() looks like the getter of
|Resource::error_|.

BUG=
==========

to

==========
Rename Resource::GetError() to FinishAsError()

In Blink Renaming, Resource::error() was incorrectly renamed to GetError().
This CL re-renames it to FinishAsError().

This CL doesn't rename it to Error() because Error() looks like the getter of
|Resource::error_|.

BUG=675877
==========

[Nate Chapin, 2017-05-02 22:59:31]

LGTM, thanks.

https://codereview.chromium.org/2855883004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/resource/ImageResource.h (right):

https://codereview.chromium.org/2855883004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/resource/ImageResource.h:86: void
FinishAsError(const ResourceError&) override;
Optional: Reorder these callbacks so that they're in the order called:
ResponseReceived -> AppendData -> {Finish, FinishAsError}

[commit-bot: I haz the power, 2017-05-03 00:45:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 00:45:42]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2017-05-04 18:39:18]

https://codereview.chromium.org/2855883004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/resource/ImageResource.h (right):

https://codereview.chromium.org/2855883004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/resource/ImageResource.h:86: void
FinishAsError(const ResourceError&) override;
On 2017/05/02 22:59:31, Nate Chapin wrote:
> Optional: Reorder these callbacks so that they're in the order called:
> ResponseReceived -> AppendData -> {Finish, FinishAsError}

Done.

[hiroshige, 2017-05-04 18:39:21]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2017-05-04 18:39:21]

The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org
Link to the patchset: https://codereview.chromium.org/2855883004/#ps20001
(title: "Reorder declarations")

[commit-bot: I haz the power, 2017-05-04 18:40:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 18:45:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 18:45:03]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[hiroshige, 2017-05-04 19:00:14]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 19:00:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 21:15:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 21:15:53]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2017-05-04 21:57:00]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2017-05-04 21:57:00]

The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org
Link to the patchset: https://codereview.chromium.org/2855883004/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-04 21:57:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 22:05:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493935020368550,
"parent_rev": "ac81f80324d1a9f0eb13b2ddf29fd3cbfaf64122", "commit_rev":
"270315a23344b1ca5a714d1e4d1f76fbbab43538"}

[commit-bot: I haz the power, 2017-05-04 22:05:35]

Description was changed from

==========
Rename Resource::GetError() to FinishAsError()

In Blink Renaming, Resource::error() was incorrectly renamed to GetError().
This CL re-renames it to FinishAsError().

This CL doesn't rename it to Error() because Error() looks like the getter of
|Resource::error_|.

BUG=675877
==========

to

==========
Rename Resource::GetError() to FinishAsError()

In Blink Renaming, Resource::error() was incorrectly renamed to GetError().
This CL re-renames it to FinishAsError().

This CL doesn't rename it to Error() because Error() looks like the getter of
|Resource::error_|.

BUG=675877

Review-Url: https://codereview.chromium.org/2855883004
Cr-Commit-Position: refs/heads/master@{#469487}
Committed:
https://chromium.googlesource.com/chromium/src/+/270315a23344b1ca5a714d1e4d1f...
==========

[commit-bot: I haz the power, 2017-05-04 22:05:36]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/270315a23344b1ca5a714d1e4d1f...