Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: third_party/WebKit/Source/core/loader/resource/ImageResource.h

Issue 2855883004: Rename Resource::GetError() to FinishAsError() (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org> 3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org>
4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
5 Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 6
7 This library is free software; you can redistribute it and/or 7 This library is free software; you can redistribute it and/or
8 modify it under the terms of the GNU Library General Public 8 modify it under the terms of the GNU Library General Public
9 License as published by the Free Software Foundation; either 9 License as published by the Free Software Foundation; either
10 version 2 of the License, or (at your option) any later version. 10 version 2 of the License, or (at your option) any later version.
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 75
76 void DidAddClient(ResourceClient*) override; 76 void DidAddClient(ResourceClient*) override;
77 77
78 ResourcePriority PriorityFromObservers() override; 78 ResourcePriority PriorityFromObservers() override;
79 79
80 void AllClientsAndObserversRemoved() override; 80 void AllClientsAndObserversRemoved() override;
81 81
82 bool CanReuse(const FetchParameters&) const override; 82 bool CanReuse(const FetchParameters&) const override;
83 83
84 PassRefPtr<const SharedBuffer> ResourceBuffer() const override; 84 PassRefPtr<const SharedBuffer> ResourceBuffer() const override;
85 void AppendData(const char*, size_t) override;
86 void GetError(const ResourceError&) override;
87 void ResponseReceived(const ResourceResponse&, 85 void ResponseReceived(const ResourceResponse&,
88 std::unique_ptr<WebDataConsumerHandle>) override; 86 std::unique_ptr<WebDataConsumerHandle>) override;
87 void AppendData(const char*, size_t) override;
89 void Finish(double finish_time = 0.0) override; 88 void Finish(double finish_time = 0.0) override;
89 void FinishAsError(const ResourceError&) override;
90 90
91 // For compatibility, images keep loading even if there are HTTP errors. 91 // For compatibility, images keep loading even if there are HTTP errors.
92 bool ShouldIgnoreHTTPStatusCodeErrors() const override { return true; } 92 bool ShouldIgnoreHTTPStatusCodeErrors() const override { return true; }
93 93
94 bool IsImage() const override { return true; } 94 bool IsImage() const override { return true; }
95 95
96 // MultipartImageResourceParser::Client 96 // MultipartImageResourceParser::Client
97 void OnePartInMultipartReceived(const ResourceResponse&) final; 97 void OnePartInMultipartReceived(const ResourceResponse&) final;
98 void MultipartDataReceived(const char*, size_t) final; 98 void MultipartDataReceived(const char*, size_t) final;
99 99
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 170
171 Timer<ImageResource> flush_timer_; 171 Timer<ImageResource> flush_timer_;
172 double last_flush_time_ = 0.; 172 double last_flush_time_ = 0.;
173 }; 173 };
174 174
175 DEFINE_RESOURCE_TYPE_CASTS(Image); 175 DEFINE_RESOURCE_TYPE_CASTS(Image);
176 176
177 } // namespace blink 177 } // namespace blink
178 178
179 #endif 179 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698