Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Unified Diff: third_party/WebKit/Source/core/loader/resource/ImageResource.h

Issue 2855883004: Rename Resource::GetError() to FinishAsError() (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/resource/ImageResource.h
diff --git a/third_party/WebKit/Source/core/loader/resource/ImageResource.h b/third_party/WebKit/Source/core/loader/resource/ImageResource.h
index 2df41d23683fa6eb12cb25a2e1511b2a832049a0..a496ca6aabbed658b3e2195c466398d70467b36f 100644
--- a/third_party/WebKit/Source/core/loader/resource/ImageResource.h
+++ b/third_party/WebKit/Source/core/loader/resource/ImageResource.h
@@ -82,11 +82,11 @@ class CORE_EXPORT ImageResource final
bool CanReuse(const FetchParameters&) const override;
PassRefPtr<const SharedBuffer> ResourceBuffer() const override;
- void AppendData(const char*, size_t) override;
- void GetError(const ResourceError&) override;
void ResponseReceived(const ResourceResponse&,
std::unique_ptr<WebDataConsumerHandle>) override;
+ void AppendData(const char*, size_t) override;
void Finish(double finish_time = 0.0) override;
+ void FinishAsError(const ResourceError&) override;
// For compatibility, images keep loading even if there are HTTP errors.
bool ShouldIgnoreHTTPStatusCodeErrors() const override { return true; }

Powered by Google App Engine
This is Rietveld 408576698