third_party/WebKit/Source/platform/loader/fetch/Resource.h - Issue 2855883004: Rename Resource::GetError() to FinishAsError()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/loader/fetch/Resource.h

Issue 2855883004: Rename Resource::GetError() to FinishAsError() (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/loader/fetch/Resource.h

diff --git a/third_party/WebKit/Source/platform/loader/fetch/Resource.h b/third_party/WebKit/Source/platform/loader/fetch/Resource.h

index 0054b138e7b1deeeee0105eaa03f6bee4a0089ac..eff9c9ab797ced36b39be8da44c07734be29e660 100644

--- a/third_party/WebKit/Source/platform/loader/fetch/Resource.h

+++ b/third_party/WebKit/Source/platform/loader/fetch/Resource.h

@@ -106,7 +106,7 @@ class PLATFORM_EXPORT Resource : public GarbageCollectedFinalized<Resource>,

virtual void SetEncoding(const String&) {}

virtual String Encoding() const { return String(); }

virtual void AppendData(const char*, size_t);

- virtual void GetError(const ResourceError&);

+ virtual void FinishAsError(const ResourceError&);

virtual void SetCORSFailed() {}

void SetNeedsSynchronousCacheHit(bool needs_synchronous_cache_hit) {