Rename Resource::GetError() to FinishAsError()

third_party/WebKit/Source/core/loader/resource/ImageResource.h

 /*
     Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
     Copyright (C) 2001 Dirk Mueller <mueller@kde.org>
     Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
     Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
     License as published by the Free Software Foundation; either
     version 2 of the License, or (at your option) any later version.
@@ skipping 65 matching lines @@
   void DidAddClient(ResourceClient*) override;
 
   ResourcePriority PriorityFromObservers() override;
 
   void AllClientsAndObserversRemoved() override;
 
   bool CanReuse(const FetchParameters&) const override;
 
   PassRefPtr<const SharedBuffer> ResourceBuffer() const override;
   void AppendData(const char*, size_t) override;
-  void GetError(const ResourceError&) override;
+  void FinishAsError(const ResourceError&) override;

[Nate Chapin, 2017/05/02 22:59:31]

Optional: Reorder these callbacks so that they're in the order called:
ResponseReceived -> AppendData -> {Finish, FinishAsError}

[hiroshige, 2017/05/04 18:39:18]

Done.

   void ResponseReceived(const ResourceResponse&,
                         std::unique_ptr<WebDataConsumerHandle>) override;
   void Finish(double finish_time = 0.0) override;
 
   // For compatibility, images keep loading even if there are HTTP errors.
   bool ShouldIgnoreHTTPStatusCodeErrors() const override { return true; }
 
   bool IsImage() const override { return true; }
 
   // MultipartImageResourceParser::Client
@@ skipping 73 matching lines @@
 
   Timer<ImageResource> flush_timer_;
   double last_flush_time_ = 0.;
 };
 
 DEFINE_RESOURCE_TYPE_CASTS(Image);
 
 }  // namespace blink
 
 #endif