Updating Opus to a pre-release of 1.1

Updating Opus to a pre-release of 1.1

This CL updates Opus to a pre-release of the coming Opus 1.1 version. The code is extracted from http://git.xiph.org/?p=opus.git, commit aee4d8057632ea0cfc1d55d88acf8466b47b7b4b from October 1st 2013.
This version includes both algorithmic and platform optimizations, as well an important fix for a denorm problem when the input goes silent after active audio. The problem causes high CPU usage.

[tlegrand1, 2013-10-18 08:27:38]

Hi Sergey & Henrik,

Sergey, here is the updated version of Opus we were discussing the other day.

Henrik, can you help review, since Sergey will be OOO?

Thanks,
Tina.

[henrika (OOO until Aug 14), 2013-10-18 08:54:58]

I don't know the details well enough to make a final call here.

What is the goal? Shall it replace the existing version or be used as an
alternative? If alternative; how to select?

The CL contains no TEST label. What tests can be executed to verify that the
codec works as intended.

Why are there building files (.sln, vcxproj files etc.)? Isn't this coded built
using the gyp structure?

Some files are marked A and others A+. What is the difference?

[henrika (OOO until Aug 14), 2013-10-18 08:55:56]

Also, if I press the Commit button; is this code actually executed at all?

[tlegrand1, 2013-10-18 10:30:58]

Hi Henrik,

I fully understand your concerns. This is how it is done: We have extracted a
snapshot of the opus git-repository located at http://git.xiph.org/?p=opus.git.
We have made no changes, nor excluded any files from that directory. That is why
you see .sln and vcxproj files, etc. Those files will not be used in Chromium.
There will be a follow-up cl that updates the file opus.gyp located in
/chromium/trunk/src/third_party/opus/.
The code will not be used until either the chromium trunk/src/DEPS
(http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?view=log) or the WebRTC
trunk/DEPS (https://code.google.com/p/webrtc/source/browse/trunk/DEPS) get
updated.

This particular update is a non-released version that have been tested briefly
in WebRTC, and is need to continue testing in WebRTC. We will do a new update as
soon as the Opus version 1.1 is released.

Did this answer your questions?

/Tina


On 2013/10/18 08:55:56, henrika wrote:
> Also, if I press the Commit button; is this code actually executed at all?

[henrika (OOO until Aug 14), 2013-10-18 10:43:36]

Thanks, then I understand better and shall not delay you any further.

LGTM

[commit-bot: I haz the power, 2013-10-22 11:17:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tlegrand@chromium.org/28553003/1

[commit-bot: I haz the power, 2013-10-22 11:19:58]

Failed to apply patch for third_party/opus/win32/genversion.bat:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file third_party/opus/win32/genversion.bat
  Hunk #1 FAILED at 2.
  Hunk #2 FAILED at 16.
  Hunk #3 FAILED at 26.
  Hunk #4 FAILED at 35.
  4 out of 4 hunks FAILED -- saving rejects to file
third_party/opus/win32/genversion.bat.rej

Patch:       third_party/opus/win32/genversion.bat
Index: win32/genversion.bat
diff --git third_party/opus/win32/genversion.bat
third_party/opus/win32/genversion.bat
index
7934ebfa102acb8f6b240b188069839d671d5e5a..e8ebb026bb61111552bde7877cfcb3e63a441f2f
100644
--- a/third_party/opus/win32/genversion.bat
+++ b/third_party/opus/win32/genversion.bat
@@ -2,7 +2,7 @@
 
 setlocal enableextensions enabledelayedexpansion
 
-for /f %%v in ('git describe --tags --match "v*"') do set version=%%v
+for /f %%v in ('git --git-dir="%~dp0..\.git" describe --tags --match "v*"
--always') do set version=%%v
 
 if not "%version%"=="" goto :gotversion
 
@@ -16,7 +16,7 @@ goto :gotversion
 
 :getversion
 
-for /f "delims== tokens=2" %%v in (%~dp0..\version.mk) do set version=%%v
+for /f "delims== tokens=2" %%v in (%~dps0..\version.mk) do set version=%%v
 
 set version=!version:^"=!
 set version=!version: =!
@@ -26,7 +26,7 @@ set version=!version: =!
 set version_out=#define %2 "%version%"
 set version_mk=%2 = "%version%"
 
-echo %version_out%> %1_temp
+echo %version_out%> "%1_temp"
 
 if %version%==unknown goto :skipgenerate
 
@@ -35,12 +35,12 @@ echo %version_mk%>> "%~dp0..\version.mk"
 
 :skipgenerate
 
-echo n | comp %1_temp %1 > NUL 2> NUL
+echo n | comp "%1_temp" "%1" > NUL 2> NUL
 
 if not errorlevel 1 goto exit
 
-copy /y %1_temp %1
+copy /y "%1_temp" "%1"
 
 :exit
 
-del %1_temp
+del "%1_temp"

[tlegrand1, 2013-10-22 12:20:11]

I'm going to need help committing this CL. Seems it only fails on one file,
though.

On 2013/10/22 11:19:58, I haz the power (commit-bot) wrote:
> Failed to apply patch for third_party/opus/win32/genversion.bat:
> While running patch -p1 --forward --force --no-backup-if-mismatch;
>   patching file third_party/opus/win32/genversion.bat
>   Hunk #1 FAILED at 2.
>   Hunk #2 FAILED at 16.
>   Hunk #3 FAILED at 26.
>   Hunk #4 FAILED at 35.
>   4 out of 4 hunks FAILED -- saving rejects to file
> third_party/opus/win32/genversion.bat.rej
> 
> Patch:       third_party/opus/win32/genversion.bat
> Index: win32/genversion.bat
> diff --git third_party/opus/win32/genversion.bat
> third_party/opus/win32/genversion.bat
> index
>
7934ebfa102acb8f6b240b188069839d671d5e5a..e8ebb026bb61111552bde7877cfcb3e63a441f2f
> 100644
> --- a/third_party/opus/win32/genversion.bat
> +++ b/third_party/opus/win32/genversion.bat
> @@ -2,7 +2,7 @@
>  
>  setlocal enableextensions enabledelayedexpansion
>  
> -for /f %%v in ('git describe --tags --match "v*"') do set version=%%v
> +for /f %%v in ('git --git-dir="%~dp0..\.git" describe --tags --match "v*"
> --always') do set version=%%v
>  
>  if not "%version%"=="" goto :gotversion
>  
> @@ -16,7 +16,7 @@ goto :gotversion
>  
>  :getversion
>  
> -for /f "delims== tokens=2" %%v in (%~dp0..\version.mk) do set version=%%v
> +for /f "delims== tokens=2" %%v in (%~dps0..\version.mk) do set version=%%v
>  
>  set version=!version:^"=!
>  set version=!version: =!
> @@ -26,7 +26,7 @@ set version=!version: =!
>  set version_out=#define %2 "%version%"
>  set version_mk=%2 = "%version%"
>  
> -echo %version_out%> %1_temp
> +echo %version_out%> "%1_temp"
>  
>  if %version%==unknown goto :skipgenerate
>  
> @@ -35,12 +35,12 @@ echo %version_mk%>> "%~dp0..\version.mk"
>  
>  :skipgenerate
>  
> -echo n | comp %1_temp %1 > NUL 2> NUL
> +echo n | comp "%1_temp" "%1" > NUL 2> NUL
>  
>  if not errorlevel 1 goto exit
>  
> -copy /y %1_temp %1
> +copy /y "%1_temp" "%1"
>  
>  :exit
>  
> -del %1_temp
> +del "%1_temp"

[henrika (OOO until Aug 14), 2013-10-22 12:41:51]

Being an owner does not help if the patch can't be applied. An owner can only
use dcommit if the patch works but if some unrelated trybots fails. You must
ensure that the patch can be applied locally first on TOT, upload rebased patch
and then commit again.

[commit-bot: I haz the power, 2013-10-23 08:58:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tlegrand@chromium.org/28553003/1

[commit-bot: I haz the power, 2013-10-23 08:59:36]

Failed to apply patch for third_party/opus/win32/genversion.bat:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file third_party/opus/win32/genversion.bat
  Hunk #1 FAILED at 2.
  Hunk #2 FAILED at 16.
  Hunk #3 FAILED at 26.
  Hunk #4 FAILED at 35.
  4 out of 4 hunks FAILED -- saving rejects to file
third_party/opus/win32/genversion.bat.rej

Patch:       third_party/opus/win32/genversion.bat
Index: win32/genversion.bat
diff --git third_party/opus/win32/genversion.bat
third_party/opus/win32/genversion.bat
index
7934ebfa102acb8f6b240b188069839d671d5e5a..e8ebb026bb61111552bde7877cfcb3e63a441f2f
100644
--- a/third_party/opus/win32/genversion.bat
+++ b/third_party/opus/win32/genversion.bat
@@ -2,7 +2,7 @@
 
 setlocal enableextensions enabledelayedexpansion
 
-for /f %%v in ('git describe --tags --match "v*"') do set version=%%v
+for /f %%v in ('git --git-dir="%~dp0..\.git" describe --tags --match "v*"
--always') do set version=%%v
 
 if not "%version%"=="" goto :gotversion
 
@@ -16,7 +16,7 @@ goto :gotversion
 
 :getversion
 
-for /f "delims== tokens=2" %%v in (%~dp0..\version.mk) do set version=%%v
+for /f "delims== tokens=2" %%v in (%~dps0..\version.mk) do set version=%%v
 
 set version=!version:^"=!
 set version=!version: =!
@@ -26,7 +26,7 @@ set version=!version: =!
 set version_out=#define %2 "%version%"
 set version_mk=%2 = "%version%"
 
-echo %version_out%> %1_temp
+echo %version_out%> "%1_temp"
 
 if %version%==unknown goto :skipgenerate
 
@@ -35,12 +35,12 @@ echo %version_mk%>> "%~dp0..\version.mk"
 
 :skipgenerate
 
-echo n | comp %1_temp %1 > NUL 2> NUL
+echo n | comp "%1_temp" "%1" > NUL 2> NUL
 
 if not errorlevel 1 goto exit
 
-copy /y %1_temp %1
+copy /y "%1_temp" "%1"
 
 :exit
 
-del %1_temp
+del "%1_temp"

[commit-bot: I haz the power, 2013-10-23 09:10:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tlegrand@chromium.org/28553003/1250001

[commit-bot: I haz the power, 2013-10-23 09:13:54]

Change committed as 230378