Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2851103002: Update some host_resolver()->AddRules in chrome/browser. (Closed)

Created:
3 years, 7 months ago by jam
Modified:
3 years, 7 months ago
CC:
aboxhall+watch_chromium.org, achuith+watch_chromium.org, alemate+watch_chromium.org, bnc+watch_chromium.org, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dougt+watch_chromium.org, dtseng+watch_chromium.org, eroman, extensions-reviews_chromium.org, gavinp+prer_chromium.org, gcasto+watchlist_chromium.org, je_julie, mmenke, nektar+watch_chromium.org, net-reviews_chromium.org, tburkard+watch_chromium.org, tfarina, vabr+watchlistpasswordmanager_chromium.org, vabr+watchlistlogin_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update some host_resolver()->AddRules in chrome/browser. Part 2/2. BUG=713847 Review-Url: https://codereview.chromium.org/2851103002 Cr-Commit-Position: refs/heads/master@{#468326} Committed: https://chromium.googlesource.com/chromium/src/+/1a5b558831d3e98f4a736e77753eacf8abdfd694

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -174 lines) Patch
M chrome/browser/extensions/activity_log/activity_log_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/automation/automation_apitest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/browser_action_apitest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/history/history_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/page_capture/page_capture_apitest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_apitest.cc View 7 chunks +20 lines, -17 lines 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_apitest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/webrtc_from_web_accessible_resource_browsertest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/service_worker_apitest.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/wake_event_page_apitest.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/webstore_inline_installer_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/webstore_installer_test.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/webstore_installer_test.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/window_open_apitest.cc View 10 chunks +18 lines, -14 lines 0 comments Download
M chrome/browser/net/cookie_policy_browsertest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/credential_manager_browsertest.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_manager_browsertest.cc View 5 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/password_manager/password_manager_test_base.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/pdf/pdf_extension_test.cc View 6 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc View 4 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/search_engines/template_url_scraper_browsertest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ssl/security_state_tab_helper_browser_tests.cc View 7 chunks +5 lines, -14 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 12 chunks +19 lines, -43 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 10 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/ui/login/login_handler_browsertest.cc View 6 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/accessibility/navigation_accessibility_uitest_win.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
jam
3 years, 7 months ago (2017-05-01 15:06:42 UTC) #11
Ken Rockot(use gerrit already)
lgtm
3 years, 7 months ago (2017-05-01 16:42:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851103002/20001
3 years, 7 months ago (2017-05-01 16:45:02 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 16:50:28 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1a5b558831d3e98f4a736e77753e...

Powered by Google App Engine
This is Rietveld 408576698