Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: chrome/browser/password_manager/credential_manager_browsertest.cc

Issue 2851103002: Update some host_resolver()->AddRules in chrome/browser. (Closed)
Patch Set: fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/credential_manager_browsertest.cc
diff --git a/chrome/browser/password_manager/credential_manager_browsertest.cc b/chrome/browser/password_manager/credential_manager_browsertest.cc
index 07f77a8be4186270f2b18e8b0981df374ab3f9e5..f7adf75218c4b48c390792a5969c1045bf7dbb18 100644
--- a/chrome/browser/password_manager/credential_manager_browsertest.cc
+++ b/chrome/browser/password_manager/credential_manager_browsertest.cc
@@ -24,6 +24,12 @@ class CredentialManagerBrowserTest : public PasswordManagerBrowserTestBase {
public:
CredentialManagerBrowserTest() = default;
+ void SetUpOnMainThread() override {
+ PasswordManagerBrowserTestBase::SetUpOnMainThread();
+ // Redirect all requests to localhost.
+ host_resolver()->AddRule("*", "127.0.0.1");
+ }
+
bool IsShowingAccountChooser() {
return PasswordsModelDelegateFromWebContents(WebContents())->
GetState() == password_manager::ui::CREDENTIAL_REQUEST_STATE;
@@ -101,9 +107,6 @@ IN_PROC_BROWSER_TEST_F(CredentialManagerBrowserTest,
IN_PROC_BROWSER_TEST_F(CredentialManagerBrowserTest,
StoreSavesPSLMatchedCredential) {
- // Redirect all requests to localhost.
- host_resolver()->AddRule("*", "127.0.0.1");
-
scoped_refptr<password_manager::TestPasswordStore> password_store =
static_cast<password_manager::TestPasswordStore*>(
PasswordStoreFactory::GetForProfile(
« no previous file with comments | « chrome/browser/net/cookie_policy_browsertest.cc ('k') | chrome/browser/password_manager/password_manager_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698