Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6560)

Unified Diff: chrome/browser/extensions/api/page_capture/page_capture_apitest.cc

Issue 2851103002: Update some host_resolver()->AddRules in chrome/browser. (Closed)
Patch Set: fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/page_capture/page_capture_apitest.cc
diff --git a/chrome/browser/extensions/api/page_capture/page_capture_apitest.cc b/chrome/browser/extensions/api/page_capture/page_capture_apitest.cc
index 035b46242d7a81c73cb21ce3b4678e3a8a5be20e..8cb98ee50adad108e91e12ad7e60eef755597554 100644
--- a/chrome/browser/extensions/api/page_capture/page_capture_apitest.cc
+++ b/chrome/browser/extensions/api/page_capture/page_capture_apitest.cc
@@ -23,6 +23,10 @@ class ExtensionPageCaptureApiTest : public ExtensionApiTest {
ExtensionApiTest::SetUpCommandLine(command_line);
command_line->AppendSwitchASCII(switches::kJavaScriptFlags, "--expose-gc");
}
+ void SetUpOnMainThread() override {
+ ExtensionApiTest::SetUpOnMainThread();
+ host_resolver()->AddRule("*", "127.0.0.1");
+ }
};
class PageCaptureSaveAsMHTMLDelegate
@@ -44,7 +48,6 @@ class PageCaptureSaveAsMHTMLDelegate
};
IN_PROC_BROWSER_TEST_F(ExtensionPageCaptureApiTest, SaveAsMHTML) {
- host_resolver()->AddRule("www.a.com", "127.0.0.1");
ASSERT_TRUE(StartEmbeddedTestServer());
PageCaptureSaveAsMHTMLDelegate delegate;
ASSERT_TRUE(RunExtensionTest("page_capture")) << message_;
@@ -62,7 +65,6 @@ IN_PROC_BROWSER_TEST_F(ExtensionPageCaptureApiTest, SaveAsMHTML) {
#if defined(OS_CHROMEOS)
IN_PROC_BROWSER_TEST_F(ExtensionPageCaptureApiTest,
PublicSessionRequestAllowed) {
- host_resolver()->AddRule("www.a.com", "127.0.0.1");
ASSERT_TRUE(StartEmbeddedTestServer());
PageCaptureSaveAsMHTMLDelegate delegate;
// Set Public Session state.
@@ -81,7 +83,6 @@ IN_PROC_BROWSER_TEST_F(ExtensionPageCaptureApiTest,
IN_PROC_BROWSER_TEST_F(ExtensionPageCaptureApiTest,
PublicSessionRequestDenied) {
- host_resolver()->AddRule("www.a.com", "127.0.0.1");
ASSERT_TRUE(StartEmbeddedTestServer());
// Set Public Session state.
chromeos::LoginState::Get()->SetLoggedInState(

Powered by Google App Engine
This is Rietveld 408576698