Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

Issue 2851103002: Update some host_resolver()->AddRules in chrome/browser. (Closed)
Patch Set: fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
diff --git a/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc b/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
index 5250c1e77cf231954f3ef5b7c953e0d25e962005..72258326412ebdbdc85a7b754950b5408d5a719f 100644
--- a/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
+++ b/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
@@ -123,6 +123,11 @@ class BrowserActionApiTest : public ExtensionApiTest {
BrowserActionApiTest() {}
~BrowserActionApiTest() override {}
+ void SetUpOnMainThread() override {
+ ExtensionApiTest::SetUpOnMainThread();
+ host_resolver()->AddRule("*", "127.0.0.1");
+ }
+
protected:
BrowserActionTestUtil* GetBrowserActionsBar() {
if (!browser_action_test_util_)
@@ -734,7 +739,6 @@ IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, TestTriggerBrowserAction) {
// primarily targets --isolate-extensions and --site-per-process modes, where
// the iframe runs in a separate process. See https://crbug.com/546267.
IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, BrowserActionPopupWithIframe) {
- host_resolver()->AddRule("*", "127.0.0.1");
ASSERT_TRUE(embedded_test_server()->Start());
ASSERT_TRUE(LoadExtension(
@@ -833,7 +837,6 @@ class NavigatingExtensionPopupBrowserTest : public BrowserActionApiTest {
void SetUpOnMainThread() override {
BrowserActionApiTest::SetUpOnMainThread();
- host_resolver()->AddRule("*", "127.0.0.1");
ASSERT_TRUE(embedded_test_server()->Start());
// Load an extension with a pop-up.

Powered by Google App Engine
This is Rietveld 408576698