Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: chrome/browser/password_manager/password_manager_browsertest.cc

Issue 2851103002: Update some host_resolver()->AddRules in chrome/browser. (Closed)
Patch Set: fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager_browsertest.cc
diff --git a/chrome/browser/password_manager/password_manager_browsertest.cc b/chrome/browser/password_manager/password_manager_browsertest.cc
index 33e6b47e3926f649ea65041bbbe7e204e586ebd9..7fab7323ea9944f60bfe60dd77ae16c30ac20d8b 100644
--- a/chrome/browser/password_manager/password_manager_browsertest.cc
+++ b/chrome/browser/password_manager/password_manager_browsertest.cc
@@ -52,7 +52,6 @@
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/test_utils.h"
#include "net/base/filename_util.h"
-#include "net/dns/mock_host_resolver.h"
#include "net/test/embedded_test_server/http_request.h"
#include "net/test/embedded_test_server/http_response.h"
#include "net/url_request/test_url_fetcher_factory.h"
@@ -2070,9 +2069,6 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
// filled in until a user interact with the form.
IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
CrossSiteIframeNotFillTest) {
- // Setup the mock host resolver
- host_resolver()->AddRule("*", "127.0.0.1");
-
// Here we need to dynamically create the iframe because the port
// embedded_test_server ran on was dynamically allocated, so the iframe's src
// attribute can only be determined at run time.
@@ -2231,9 +2227,6 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
return;
}
- // Setup the mock host resolver
- host_resolver()->AddRule("*", "127.0.0.1");
-
// Navigate the main frame.
GURL main_frame_url = embedded_test_server()->GetURL(
"/password/password_form_in_crosssite_iframe.html");
@@ -3273,7 +3266,6 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestWarning,
// We need to serve from a non-localhost context for the form to be treated as
// Not Secure.
- host_resolver()->AddRule("example.com", "127.0.0.1");
NavigationObserver observer(WebContents());
ui_test_utils::NavigateToURL(
browser(), embedded_test_server()->GetURL(
@@ -3329,7 +3321,6 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestWarning,
// We need to serve from a non-localhost context for the form to be treated as
// Not Secure.
- host_resolver()->AddRule("example.com", "127.0.0.1");
NavigationObserver observer(WebContents());
ui_test_utils::NavigateToURL(
browser(), embedded_test_server()->GetURL(

Powered by Google App Engine
This is Rietveld 408576698