Move WebViewFrameWidget to use WebViewBase rather than WebViewImpl.

Move WebViewFrameWidget to use WebViewBase rather than WebViewImpl.

We WebViewFrameWidget keeps a RefPtr to WebViewImpl we need to make WebViewBase
ref counted. Removed the ref counted from WebViewImpl when moving it to
WebViewBase.

BUG=712963
Review-Url: https://codereview.chromium.org/2850113002
Cr-Commit-Position: refs/heads/master@{#468310}
Committed: https://chromium.googlesource.com/chromium/src/+/660e8283b061c57654c8beb9791567b637842cf2

[slangley, 2017-05-01 03:26:02]

Description was changed from

==========
Move WebViewFrameWidget to use WebViewBase rather than WebViewImpl.

We WebViewFrameWidget keeps a RefPtr to WebViewImpl we need to make WebViewBase
ref counted. Removed the ref counted from WebViewImpl when moving it to
WebViewBase.

BUG=
==========

to

==========
Move WebViewFrameWidget to use WebViewBase rather than WebViewImpl.

We WebViewFrameWidget keeps a RefPtr to WebViewImpl we need to make WebViewBase
ref counted. Removed the ref counted from WebViewImpl when moving it to
WebViewBase.

BUG=712963
==========

[slangley, 2017-05-01 03:59:15]

slangley@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2017-05-01 07:34:26]

https://codereview.chromium.org/2850113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/exported/WebViewBase.h (right):

https://codereview.chromium.org/2850113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/exported/WebViewBase.h:159: virtual void
SetCompositorVisibility(bool) = 0;

I don't fully understand the changes at line 159 - 175. Why are the changes
needed?

https://codereview.chromium.org/2850113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/exported/WebViewBase.h:165: // focused frame, or
if the there is one but it belongs to a different local

if there is

[slangley, 2017-05-01 09:26:58]

haraken@ - ptal

https://codereview.chromium.org/2850113002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/exported/WebViewBase.h (right):

https://codereview.chromium.org/2850113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/exported/WebViewBase.h:159: virtual void
SetCompositorVisibility(bool) = 0;
On 2017/05/01 at 07:34:26, haraken wrote:
> I don't fully understand the changes at line 159 - 175. Why are the changes
needed?

Making methods that are currently not defined as virtual in WebViewImpl virtual
so we can substitute WebViewBase for WebViewImpl. In some cases the methods are
pulled down from WebViewWidget and we need to import them here so they're
defined in WebViewBase publicly.

You'll see the corresponding methods in WebViewImpl changed to override these
virtual methods.

https://codereview.chromium.org/2850113002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/exported/WebViewBase.h:165: // focused frame, or
if the there is one but it belongs to a different local
On 2017/05/01 at 07:34:26, haraken wrote:
> if there is

Done

[haraken, 2017-05-01 09:33:30]

On 2017/05/01 09:26:58, slangley wrote:
> haraken@ - ptal
> 
>
https://codereview.chromium.org/2850113002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/exported/WebViewBase.h (right):
> 
>
https://codereview.chromium.org/2850113002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/exported/WebViewBase.h:159: virtual void
> SetCompositorVisibility(bool) = 0;
> On 2017/05/01 at 07:34:26, haraken wrote:
> > I don't fully understand the changes at line 159 - 175. Why are the changes
> needed?
> 
> Making methods that are currently not defined as virtual in WebViewImpl
virtual
> so we can substitute WebViewBase for WebViewImpl. In some cases the methods
are
> pulled down from WebViewWidget and we need to import them here so they're
> defined in WebViewBase publicly.
> 
> You'll see the corresponding methods in WebViewImpl changed to override these
> virtual methods.

Yeah, thanks. I figured it out while looking at the other CL :)

>
https://codereview.chromium.org/2850113002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/exported/WebViewBase.h:165: // focused frame,
or
> if the there is one but it belongs to a different local
> On 2017/05/01 at 07:34:26, haraken wrote:
> > if there is
> 
> Done


LGTM.

[slangley, 2017-05-01 11:26:50]

The CQ bit was checked by slangley@chromium.org

[commit-bot: I haz the power, 2017-05-01 11:27:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 13:05:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493638010640620,
"parent_rev": "51b208180cdd9881d699b7d28273d7addbce69fb", "commit_rev":
"660e8283b061c57654c8beb9791567b637842cf2"}

[commit-bot: I haz the power, 2017-05-01 13:05:27]

Description was changed from

==========
Move WebViewFrameWidget to use WebViewBase rather than WebViewImpl.

We WebViewFrameWidget keeps a RefPtr to WebViewImpl we need to make WebViewBase
ref counted. Removed the ref counted from WebViewImpl when moving it to
WebViewBase.

BUG=712963
==========

to

==========
Move WebViewFrameWidget to use WebViewBase rather than WebViewImpl.

We WebViewFrameWidget keeps a RefPtr to WebViewImpl we need to make WebViewBase
ref counted. Removed the ref counted from WebViewImpl when moving it to
WebViewBase.

BUG=712963

Review-Url: https://codereview.chromium.org/2850113002
Cr-Commit-Position: refs/heads/master@{#468310}
Committed:
https://chromium.googlesource.com/chromium/src/+/660e8283b061c57654c8beb97915...
==========

[commit-bot: I haz the power, 2017-05-01 13:05:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/660e8283b061c57654c8beb97915...