Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: third_party/WebKit/Source/core/exported/WebViewBase.h

Issue 2850113002: Move WebViewFrameWidget to use WebViewBase rather than WebViewImpl. (Closed)
Patch Set: Fix code review comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/WebViewFrameWidget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/exported/WebViewBase.h
diff --git a/third_party/WebKit/Source/core/exported/WebViewBase.h b/third_party/WebKit/Source/core/exported/WebViewBase.h
index ae72b40d8b1c173ec308396f19142eb2e5d82937..9fed5b7e44fdf8556914d274e1575913ab7c3982 100644
--- a/third_party/WebKit/Source/core/exported/WebViewBase.h
+++ b/third_party/WebKit/Source/core/exported/WebViewBase.h
@@ -6,6 +6,7 @@
#define WebViewBase_h
#include "platform/transforms/TransformationMatrix.h"
+#include "platform/wtf/RefCounted.h"
#include "public/platform/WebDisplayMode.h"
#include "public/platform/WebInputEventResult.h"
#include "public/web/WebElement.h"
@@ -13,18 +14,24 @@
namespace blink {
+class AnimationWorkletProxyClient;
+class CompositorAnimationHost;
+class CompositorWorkerProxyClient;
class CompositorAnimationTimeline;
class ContextMenuProvider;
class DevToolsEmulator;
class Frame;
class GraphicsLayer;
+class HitTestResult;
class Page;
class PaintLayerCompositor;
class PagePopup;
class PagePopupClient;
class PageScaleConstraintsSet;
class WebInputEvent;
+class WebInputMethodControllerImpl;
class WebKeyboardEvent;
+class WebLayer;
class WebLocalFrameImpl;
class WebLayerTreeView;
class WebPagePopupImpl;
@@ -38,8 +45,10 @@ struct WebRect;
//
// Once WebViewImpl is moved from web to core/exported then this class should be
// removed and clients can once again depend on WebViewImpl.
-class WebViewBase : public WebView {
+class WebViewBase : public WebView, public RefCounted<WebViewBase> {
public:
+ virtual ~WebViewBase() {}
+
virtual void SetBaseBackgroundColor(WebColor) = 0;
virtual void SetBaseBackgroundColorOverride(WebColor) = 0;
virtual void ClearBaseBackgroundColorOverride() = 0;
@@ -146,6 +155,24 @@ class WebViewBase : public WebView {
virtual double LastFrameTimeMonotonic() const = 0;
static const WebInputEvent* CurrentInputEvent();
+
+ virtual void SetCompositorVisibility(bool) = 0;
+ using WebWidget::SetSuppressFrameRequestsWorkaroundFor704763Only;
+ using WebWidget::RecordWheelAndTouchScrollingCount;
+ using WebWidget::GetCompositionCharacterBounds;
+ // Returns the currently active WebInputMethodController which is the one
+ // corresponding to the focused frame. It will return nullptr if there is no
+ // focused frame, or if there is one but it belongs to a different local
+ // root.
+ virtual WebInputMethodControllerImpl* GetActiveWebInputMethodController()
+ const = 0;
+ virtual void ScheduleAnimationForWidget() = 0;
+ virtual CompositorWorkerProxyClient* CreateCompositorWorkerProxyClient() = 0;
+ virtual AnimationWorkletProxyClient* CreateAnimationWorkletProxyClient() = 0;
+ virtual void SetRootGraphicsLayer(GraphicsLayer*) = 0;
+ virtual void SetRootLayer(WebLayer*) = 0;
+ virtual CompositorAnimationHost* AnimationHost() const = 0;
+ virtual HitTestResult CoreHitTestResultAt(const WebPoint&) = 0;
};
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/WebViewFrameWidget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698