Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2850113002: Move WebViewFrameWidget to use WebViewBase rather than WebViewImpl. (Closed)
Patch Set: Fix code review comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebViewFrameWidget.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewImpl.h
diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h
index 19ecc321cebe29dc3b7acd77d4ac105b26a22e64..9a18d090efab69f9474356c79ac08ed143fa1823 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.h
+++ b/third_party/WebKit/Source/web/WebViewImpl.h
@@ -44,7 +44,6 @@
#include "platform/scheduler/child/web_scheduler.h"
#include "platform/wtf/Compiler.h"
#include "platform/wtf/HashSet.h"
-#include "platform/wtf/RefCounted.h"
#include "platform/wtf/Vector.h"
#include "public/platform/WebDisplayMode.h"
#include "public/platform/WebFloatSize.h"
@@ -98,7 +97,6 @@ class WebViewScheduler;
class WEB_EXPORT WebViewImpl final
: NON_EXPORTED_BASE(public WebViewBase),
- public RefCounted<WebViewImpl>,
NON_EXPORTED_BASE(public WebGestureCurveTarget),
public PageWidgetEventHandler,
public WebScheduler::InterventionReporter,
@@ -267,7 +265,7 @@ class WEB_EXPORT WebViewImpl final
float ClampPageScaleFactorToLimits(float) const override;
void ResetScaleStateImmediately() override;
- HitTestResult CoreHitTestResultAt(const WebPoint&);
+ HitTestResult CoreHitTestResultAt(const WebPoint&) override;
void InvalidateRect(const IntRect&) override;
void SetBaseBackgroundColor(WebColor) override;
@@ -462,7 +460,7 @@ class WEB_EXPORT WebViewImpl final
WebRect ComputeBlockBound(const WebPoint&, bool ignore_clipping);
WebLayerTreeView* LayerTreeView() const override { return layer_tree_view_; }
- CompositorAnimationHost* AnimationHost() const {
+ CompositorAnimationHost* AnimationHost() const override {
return animation_host_.get();
}
@@ -482,8 +480,8 @@ class WEB_EXPORT WebViewImpl final
void ForceNextWebGLContextCreationToFail() override;
void ForceNextDrawingBufferCreationToFail() override;
- CompositorWorkerProxyClient* CreateCompositorWorkerProxyClient();
- AnimationWorkletProxyClient* CreateAnimationWorkletProxyClient();
+ CompositorWorkerProxyClient* CreateCompositorWorkerProxyClient() override;
+ AnimationWorkletProxyClient* CreateAnimationWorkletProxyClient() override;
IntSize MainFrameSize() override;
WebDisplayMode DisplayMode() const override { return display_mode_; }
@@ -529,10 +527,10 @@ class WEB_EXPORT WebViewImpl final
// Overrides the compositor visibility. See the description of
// m_overrideCompositorVisibility for more details.
- void SetCompositorVisibility(bool);
+ void SetCompositorVisibility(bool) override;
// TODO(lfg): Remove once WebViewFrameWidget is deleted.
- void ScheduleAnimationForWidget();
+ void ScheduleAnimationForWidget() override;
bool GetCompositionCharacterBounds(WebVector<WebRect>&) override;
void UpdateBaseBackgroundColor();
@@ -594,8 +592,8 @@ class WEB_EXPORT WebViewImpl final
float DeviceScaleFactor() const;
- void SetRootGraphicsLayer(GraphicsLayer*);
- void SetRootLayer(WebLayer*);
+ void SetRootGraphicsLayer(GraphicsLayer*) override;
+ void SetRootLayer(WebLayer*) override;
void AttachCompositorAnimationTimeline(CompositorAnimationTimeline*);
void DetachCompositorAnimationTimeline(CompositorAnimationTimeline*);
« no previous file with comments | « third_party/WebKit/Source/web/WebViewFrameWidget.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698