Move WebViewFrameWidget to use WebViewBase rather than WebViewImpl.

third_party/WebKit/Source/core/exported/WebViewBase.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.#ifndef WebViewBase_h
 
 #ifndef WebViewBase_h
 #define WebViewBase_h
 
 #include "platform/transforms/TransformationMatrix.h"
+#include "platform/wtf/RefCounted.h"
 #include "public/platform/WebDisplayMode.h"
 #include "public/platform/WebInputEventResult.h"
 #include "public/web/WebElement.h"
 #include "public/web/WebView.h"
 
 namespace blink {
 
+class AnimationWorkletProxyClient;
+class CompositorAnimationHost;
+class CompositorWorkerProxyClient;
 class CompositorAnimationTimeline;
 class ContextMenuProvider;
 class DevToolsEmulator;
 class Frame;
 class GraphicsLayer;
+class HitTestResult;
 class Page;
 class PaintLayerCompositor;
 class PagePopup;
 class PagePopupClient;
 class PageScaleConstraintsSet;
 class WebInputEvent;
+class WebInputMethodControllerImpl;
 class WebKeyboardEvent;
+class WebLayer;
 class WebLocalFrameImpl;
 class WebLayerTreeView;
 class WebPagePopupImpl;
 class WebSettingsImpl;
 struct WebRect;
 
 // WebViewBase is a temporary class introduced to decouple the defintion of
 // WebViewImpl from the concrete implementation. It was not possible to move the
 // defintion of these methods to WebView as we did not want to pollute the
 // public API surface area.
 //
 // Once WebViewImpl is moved from web to core/exported then this class should be
 // removed and clients can once again depend on WebViewImpl.
-class WebViewBase : public WebView {
+class WebViewBase : public WebView, public RefCounted<WebViewBase> {
  public:
+  virtual ~WebViewBase() {}
+
   virtual void SetBaseBackgroundColor(WebColor) = 0;
   virtual void SetBaseBackgroundColorOverride(WebColor) = 0;
   virtual void ClearBaseBackgroundColorOverride() = 0;
   virtual void SetBackgroundColorOverride(WebColor) = 0;
   virtual void ClearBackgroundColorOverride() = 0;
   virtual void SetZoomFactorOverride(float) = 0;
   virtual void SetCompositorDeviceScaleFactorOverride(float) = 0;
   virtual void SetDeviceEmulationTransform(const TransformationMatrix&) = 0;
   virtual void SetShowDebugBorders(bool) = 0;
 
@@ skipping 86 matching lines @@
 
   virtual GraphicsLayer* RootGraphicsLayer() = 0;
   virtual void RegisterViewportLayersWithCompositor() = 0;
   virtual PaintLayerCompositor* Compositor() const = 0;
 
   virtual void DidUpdateBrowserControls() = 0;
   virtual FloatSize ElasticOverscroll() const = 0;
   virtual double LastFrameTimeMonotonic() const = 0;
 
   static const WebInputEvent* CurrentInputEvent();
+
+  virtual void SetCompositorVisibility(bool) = 0;

[haraken, 2017/05/01 07:34:26]

I don't fully understand the changes at line 159 - 175. Why are the changes
needed?

[slangley, 2017/05/01 09:26:57]

Making methods that are currently not defined as virtual in WebViewImpl virtual
so we can substitute WebViewBase for WebViewImpl. In some cases the methods are
pulled down from WebViewWidget and we need to import them here so they're
defined in WebViewBase publicly.

You'll see the corresponding methods in WebViewImpl changed to override these
virtual methods.

+  using WebWidget::SetSuppressFrameRequestsWorkaroundFor704763Only;
+  using WebWidget::RecordWheelAndTouchScrollingCount;
+  using WebWidget::GetCompositionCharacterBounds;
+  // Returns the currently active WebInputMethodController which is the one
+  // corresponding to the focused frame. It will return nullptr if there is no
+  // focused frame, or if the there is one but it belongs to a different local

[haraken, 2017/05/01 07:34:26]

if there is

[slangley, 2017/05/01 09:26:57]

Done

+  // root.
+  virtual WebInputMethodControllerImpl* GetActiveWebInputMethodController()
+      const = 0;
+  virtual void ScheduleAnimationForWidget() = 0;
+  virtual CompositorWorkerProxyClient* CreateCompositorWorkerProxyClient() = 0;
+  virtual AnimationWorkletProxyClient* CreateAnimationWorkletProxyClient() = 0;
+  virtual void SetRootGraphicsLayer(GraphicsLayer*) = 0;
+  virtual void SetRootLayer(WebLayer*) = 0;
+  virtual CompositorAnimationHost* AnimationHost() const = 0;
+  virtual HitTestResult CoreHitTestResultAt(const WebPoint&) = 0;
 };
 }
 
 #endif