Fix a batch of DDC SDK compile errors.

Fix a batch of DDC SDK compile errors.

R=floitsch@google.com, vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/7f7c681893ece113e6f5fb3186092a45ca659baf

[Bob Nystrom, 2017-04-27 21:37:44]

Description was changed from

==========
Format.


Fix a batch of DDC SDK compile errors.
==========

to

==========
Fix a batch of DDC SDK compile errors.
==========

[Bob Nystrom, 2017-04-27 21:38:02]

rnystrom@google.com changed reviewers:
+ floitsch@google.com, vsm@google.com

[floitsch, 2017-04-27 22:10:26]

LGTM.

https://codereview.chromium.org/2848703003/diff/1/sdk/lib/io/file_impl.dart
File sdk/lib/io/file_impl.dart (right):

https://codereview.chromium.org/2848703003/diff/1/sdk/lib/io/file_impl.dart#n...
sdk/lib/io/file_impl.dart:201: Future close() => _openFuture.then((openedFile)
=> openedFile.close());
Please use my changes instead:
https://codereview.chromium.org/2764943002/

https://codereview.chromium.org/2848703003/diff/1/sdk/lib/io/file_impl.dart#n...
sdk/lib/io/file_impl.dart:557: return open(mode: mode).then((file) async {
The core libraries currently do not use 'async'. I wouldn't start here.
Especially, since there is no need.

[floitsch, 2017-04-27 22:11:29]

On 2017/04/27 22:10:26, floitsch wrote:
> LGTM.
> 
> https://codereview.chromium.org/2848703003/diff/1/sdk/lib/io/file_impl.dart
> File sdk/lib/io/file_impl.dart (right):
> 
>
https://codereview.chromium.org/2848703003/diff/1/sdk/lib/io/file_impl.dart#n...
> sdk/lib/io/file_impl.dart:201: Future close() => _openFuture.then((openedFile)
> => openedFile.close());
> Please use my changes instead:
> https://codereview.chromium.org/2764943002/
> 
>
https://codereview.chromium.org/2848703003/diff/1/sdk/lib/io/file_impl.dart#n...
> sdk/lib/io/file_impl.dart:557: return open(mode: mode).then((file) async {
> The core libraries currently do not use 'async'. I wouldn't start here.
> Especially, since there is no need.

And here is a direct link to the file changes:
https://codereview.chromium.org/2764943002/diff/80001/sdk/lib/io/file_impl.dart

[vsm, 2017-04-27 22:13:26]

lgtm

[Bob Nystrom, 2017-04-28 00:13:07]

https://codereview.chromium.org/2848703003/diff/1/sdk/lib/io/file_impl.dart
File sdk/lib/io/file_impl.dart (right):

https://codereview.chromium.org/2848703003/diff/1/sdk/lib/io/file_impl.dart#n...
sdk/lib/io/file_impl.dart:201: Future close() => _openFuture.then((openedFile)
=> openedFile.close());
On 2017/04/27 22:10:25, floitsch wrote:
> Please use my changes instead:
> https://codereview.chromium.org/2764943002/

Done. (FWIW, I changed it the way I did because _FileStream is private and every
use of its close() method I saw didn't use the result value anyway.)

https://codereview.chromium.org/2848703003/diff/1/sdk/lib/io/file_impl.dart#n...
sdk/lib/io/file_impl.dart:557: return open(mode: mode).then((file) async {
On 2017/04/27 22:10:25, floitsch wrote:
> The core libraries currently do not use 'async'. I wouldn't start here.
> Especially, since there is no need.

Took your change instead. I could have sworn I tried that same fix but it didn't
fully satisfy the type system, I think related to the body of the function
returning a Future<File> in one branch and a File in the other. Seems to be
working now. <shrug> Maybe I put the <File> on the wrong .then().

Is there a reason the core libraries don't use async? I'd expect us to want to
always dogfood the latest language features when we can.

[Bob Nystrom, 2017-04-28 00:27:09]

Description was changed from

==========
Fix a batch of DDC SDK compile errors.
==========

to

==========
Fix a batch of DDC SDK compile errors.

R=floitsch@google.com, vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7f7c681893ece113e6f5fb3186092a45ca659baf
==========

[Bob Nystrom, 2017-04-28 00:27:10]

Committed patchset #2 (id:10001) manually as
7f7c681893ece113e6f5fb3186092a45ca659baf (presubmit successful).