Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: pkg/dev_compiler/tool/input_sdk/patch/core_patch.dart

Issue 2848703003: Fix a batch of DDC SDK compile errors. (Closed)
Patch Set: Revise. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dev_compiler/lib/sdk/ddc_sdk.sum ('k') | pkg/dev_compiler/tool/input_sdk/private/annotations.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/tool/input_sdk/patch/core_patch.dart
diff --git a/pkg/dev_compiler/tool/input_sdk/patch/core_patch.dart b/pkg/dev_compiler/tool/input_sdk/patch/core_patch.dart
index ba805ac223931a35673c47f7f9724a40979052af..d6156408bff8f007fe81e0b57ebe890cd8c17ac5 100644
--- a/pkg/dev_compiler/tool/input_sdk/patch/core_patch.dart
+++ b/pkg/dev_compiler/tool/input_sdk/patch/core_patch.dart
@@ -10,13 +10,14 @@ import 'dart:_js_helper'
patch,
checkInt,
getRuntimeType,
+ getTraceFromException,
jsonEncodeNative,
JsLinkedHashMap,
JSSyntaxRegExp,
- Primitives,
- stringJoinUnchecked,
+ NoInline,
objectHashCode,
- getTraceFromException;
+ Primitives,
+ stringJoinUnchecked;
import 'dart:_foreign_helper' show JS;
@@ -131,6 +132,7 @@ class int {
@patch
factory int.fromEnvironment(String name, {int defaultValue}) {
+ // ignore: const_constructor_throws_exception
throw new UnsupportedError(
'int.fromEnvironment can only be used as a const constructor');
}
@@ -391,6 +393,7 @@ class String {
@patch
factory String.fromEnvironment(String name, {String defaultValue}) {
+ // ignore: const_constructor_throws_exception
throw new UnsupportedError(
'String.fromEnvironment can only be used as a const constructor');
}
@@ -445,6 +448,7 @@ class String {
class bool {
@patch
factory bool.fromEnvironment(String name, {bool defaultValue: false}) {
+ // ignore: const_constructor_throws_exception
throw new UnsupportedError(
'bool.fromEnvironment can only be used as a const constructor');
}
« no previous file with comments | « pkg/dev_compiler/lib/sdk/ddc_sdk.sum ('k') | pkg/dev_compiler/tool/input_sdk/private/annotations.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698