Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Side by Side Diff: sdk/lib/async/future.dart

Issue 2848703003: Fix a batch of DDC SDK compile errors. (Closed)
Patch Set: Revise. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/dev_compiler/tool/sdk_expected_errors.txt ('k') | sdk/lib/collection/queue.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart.async; 5 part of dart.async;
6 6
7 /// A type representing values that are either `Future<T>` or `T`. 7 /// A type representing values that are either `Future<T>` or `T`.
8 /// 8 ///
9 /// This class declaration is a public stand-in for an internal 9 /// This class declaration is a public stand-in for an internal
10 /// future-or-value generic type. References to this class are resolved to the 10 /// future-or-value generic type. References to this class are resolved to the
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 * the `then` call, it would not catch errors from the `bar` call. 128 * the `then` call, it would not catch errors from the `bar` call.
129 * 129 *
130 * Futures can have more than one callback-pair registered. Each successor is 130 * Futures can have more than one callback-pair registered. Each successor is
131 * treated independently and is handled as if it was the only successor. 131 * treated independently and is handled as if it was the only successor.
132 * 132 *
133 * A future may also fail to ever complete. In that case, no callbacks are 133 * A future may also fail to ever complete. In that case, no callbacks are
134 * called. 134 * called.
135 */ 135 */
136 abstract class Future<T> { 136 abstract class Future<T> {
137 // The `_nullFuture` is a completed Future with the value `null`. 137 // The `_nullFuture` is a completed Future with the value `null`.
138 static final _Future _nullFuture = new Future.value(null); 138 static final _Future<Null> _nullFuture = new Future.value(null);
139 139
140 /** 140 /**
141 * Creates a future containing the result of calling [computation] 141 * Creates a future containing the result of calling [computation]
142 * asynchronously with [Timer.run]. 142 * asynchronously with [Timer.run].
143 * 143 *
144 * If the result of executing [computation] throws, the returned future is 144 * If the result of executing [computation] throws, the returned future is
145 * completed with the error. 145 * completed with the error.
146 * 146 *
147 * If the returned value is itself a [Future], completion of 147 * If the returned value is itself a [Future], completion of
148 * the created future will wait until the returned future completes, 148 * the created future will wait until the returned future completes,
(...skipping 737 matching lines...) Expand 10 before | Expand all | Expand 10 after
886 AsyncError replacement = Zone.current.errorCallback(error, stackTrace); 886 AsyncError replacement = Zone.current.errorCallback(error, stackTrace);
887 if (replacement != null) { 887 if (replacement != null) {
888 error = _nonNullError(replacement.error); 888 error = _nonNullError(replacement.error);
889 stackTrace = replacement.stackTrace; 889 stackTrace = replacement.stackTrace;
890 } 890 }
891 result._asyncCompleteError(error, stackTrace); 891 result._asyncCompleteError(error, stackTrace);
892 } 892 }
893 893
894 /** Helper function that converts `null` to a [NullThrownError]. */ 894 /** Helper function that converts `null` to a [NullThrownError]. */
895 Object _nonNullError(Object error) => error ?? new NullThrownError(); 895 Object _nonNullError(Object error) => error ?? new NullThrownError();
OLDNEW
« no previous file with comments | « pkg/dev_compiler/tool/sdk_expected_errors.txt ('k') | sdk/lib/collection/queue.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698