Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1961)

Unified Diff: sdk/lib/core/bool.dart

Issue 2848703003: Fix a batch of DDC SDK compile errors. (Closed)
Patch Set: Revise. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/collection/queue.dart ('k') | sdk/lib/core/int.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/core/bool.dart
diff --git a/sdk/lib/core/bool.dart b/sdk/lib/core/bool.dart
index 3465527d7b067862d7524733b781845dab27326e..6660b76f58dda344090b716748eae77fbd900e9f 100644
--- a/sdk/lib/core/bool.dart
+++ b/sdk/lib/core/bool.dart
@@ -38,6 +38,12 @@ class bool {
*
* const isLoggingOn = (const String.fromEnvironment("logging") == "on");
*/
+ // The .fromEnvironment() constructors are special in that we do not want
+ // users to call them using "new". We prohibit that by giving them bodies
+ // that throw, even though const constructors are not allowed to have bodies.
+ // Disable those static errors.
+ //ignore: const_constructor_with_body
+ //ignore: const_factory
external const factory bool.fromEnvironment(String name,
{bool defaultValue: false});
« no previous file with comments | « sdk/lib/collection/queue.dart ('k') | sdk/lib/core/int.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698