Fix some strong mode issues in the core libraries.

Fix some strong mode issues in the core libraries.

R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/e5c091e048370a839919cb341fe68904b9e73207
Reverted: https://github.com/dart-lang/sdk/commit/a382f7845c034f3b97bb8532ad7247fad53494e1
Committed: https://github.com/dart-lang/sdk/commit/5aff94f980ed297305fcba6579acfdc7783cb7be

[floitsch, 2017-03-22 11:34:49]

floitsch@google.com changed reviewers:
+ vsm@google.com

[vsm, 2017-03-22 13:39:11]

one comment / question, otherwise lgtm!

https://codereview.chromium.org/2764943002/diff/40001/sdk/lib/convert/line_sp...
File sdk/lib/convert/line_splitter.dart (right):

https://codereview.chromium.org/2764943002/diff/40001/sdk/lib/convert/line_sp...
sdk/lib/convert/line_splitter.dart:22: implements Object
/*=StreamTransformer<String, String>*/ {
Can we get rid of the comment syntax here yet?

[floitsch, 2017-03-22 13:46:28]

https://codereview.chromium.org/2764943002/diff/40001/sdk/lib/convert/line_sp...
File sdk/lib/convert/line_splitter.dart (right):

https://codereview.chromium.org/2764943002/diff/40001/sdk/lib/convert/line_sp...
sdk/lib/convert/line_splitter.dart:22: implements Object
/*=StreamTransformer<String, String>*/ {
On 2017/03/22 13:39:11, vsm wrote:
> Can we get rid of the comment syntax here yet?

No. These are incompatible.

Removing the comment syntax would break non-strong mode programs.

[vsm, 2017-03-22 14:44:46]

On 2017/03/22 13:46:28, floitsch wrote:
>
https://codereview.chromium.org/2764943002/diff/40001/sdk/lib/convert/line_sp...
> File sdk/lib/convert/line_splitter.dart (right):
> 
>
https://codereview.chromium.org/2764943002/diff/40001/sdk/lib/convert/line_sp...
> sdk/lib/convert/line_splitter.dart:22: implements Object
> /*=StreamTransformer<String, String>*/ {
> On 2017/03/22 13:39:11, vsm wrote:
> > Can we get rid of the comment syntax here yet?
> 
> No. These are incompatible.
> 
> Removing the comment syntax would break non-strong mode programs.

Right.  I guess the precise question is when to make that breaking change.  Not
now is a reasonable answer.

still lgtm

[floitsch, 2017-03-22 14:59:16]

Description was changed from

==========
Fix some strong mode issues in the core libraries.
==========

to

==========
Fix some strong mode issues in the core libraries.

R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e5c091e048370a839919cb341fe68904b9e73207
==========

[floitsch, 2017-03-22 14:59:17]

Committed patchset #4 (id:60001) manually as
e5c091e048370a839919cb341fe68904b9e73207.

[floitsch, 2017-03-22 15:03:22]

On 2017/03/22 14:44:46, vsm wrote:
> On 2017/03/22 13:46:28, floitsch wrote:
> >
>
https://codereview.chromium.org/2764943002/diff/40001/sdk/lib/convert/line_sp...
> > File sdk/lib/convert/line_splitter.dart (right):
> > 
> >
>
https://codereview.chromium.org/2764943002/diff/40001/sdk/lib/convert/line_sp...
> > sdk/lib/convert/line_splitter.dart:22: implements Object
> > /*=StreamTransformer<String, String>*/ {
> > On 2017/03/22 13:39:11, vsm wrote:
> > > Can we get rid of the comment syntax here yet?
> > 
> > No. These are incompatible.
> > 
> > Removing the comment syntax would break non-strong mode programs.
> 
> Right.  I guess the precise question is when to make that breaking change. 
Not
> now is a reasonable answer.

I think the best moment is, when we stop supporting non-strong mode.

> 
> still lgtm

[floitsch, 2017-03-22 15:56:16]

Description was changed from

==========
Fix some strong mode issues in the core libraries.

R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e5c091e048370a839919cb341fe68904b9e73207
==========

to

==========
Fix some strong mode issues in the core libraries.

R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e5c091e048370a839919cb341fe68904b9e73207
Reverted:
https://github.com/dart-lang/sdk/commit/a382f7845c034f3b97bb8532ad7247fad53494e1
==========

[floitsch, 2017-03-22 16:22:24]

Had to revert.
We need to wait for a roll of scheduled_test. The current version still uses the
deprecated class.
The github version is already updated.

[floitsch, 2017-03-22 16:22:24]

Had to revert.
We need to wait for a roll of scheduled_test. The current version still uses the
deprecated class.
The github version is already updated.

[floitsch, 2017-05-01 13:20:36]

Description was changed from

==========
Fix some strong mode issues in the core libraries.

R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e5c091e048370a839919cb341fe68904b9e73207
Reverted:
https://github.com/dart-lang/sdk/commit/a382f7845c034f3b97bb8532ad7247fad53494e1
==========

to

==========
Fix some strong mode issues in the core libraries.

R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e5c091e048370a839919cb341fe68904b9e73207
Reverted:
https://github.com/dart-lang/sdk/commit/a382f7845c034f3b97bb8532ad7247fad53494e1
Committed:
https://github.com/dart-lang/sdk/commit/5aff94f980ed297305fcba6579acfdc7783cb7be
==========

[floitsch, 2017-05-01 13:20:38]

Committed patchset #6 (id:100001) manually as
5aff94f980ed297305fcba6579acfdc7783cb7be (presubmit successful).