Add a platform implementation of QuicTest and QuicTestWithParam

Add a platform implementation of QuicTest and QuicTestWithParam
to serve as the base class for all QUIC tests.

This includes code to flip flags back to their default values.

Merge internal change: 154732382

BUG=

Review-Url: https://codereview.chromium.org/2848203002
Cr-Commit-Position: refs/heads/master@{#468373}
Committed: https://chromium.googlesource.com/chromium/src/+/8458180a3b6315ff262f1bb7919519595eadcb0f

[Ryan Hamilton, 2017-05-01 02:00:24]

rch@chromium.org changed reviewers:
+ fayang@chromium.org

[Fan Yang, 2017-05-01 14:53:06]

On 2017/05/01 02:00:25, Ryan Hamilton wrote:

[Fan Yang, 2017-05-01 14:53:38]

https://codereview.chromium.org/2848203002/diff/1/net/quic/platform/impl/quic...
File net/quic/platform/impl/quic_test_impl.h (right):

https://codereview.chromium.org/2848203002/diff/1/net/quic/platform/impl/quic...
net/quic/platform/impl/quic_test_impl.h:15: QuicFlagSaver();
I did not see the definitions (as you removed from quic_test_utils.cc) of these
functions?

[Ryan Hamilton, 2017-05-01 16:46:30]

Thanks!

https://codereview.chromium.org/2848203002/diff/1/net/quic/platform/impl/quic...
File net/quic/platform/impl/quic_test_impl.h (right):

https://codereview.chromium.org/2848203002/diff/1/net/quic/platform/impl/quic...
net/quic/platform/impl/quic_test_impl.h:15: QuicFlagSaver();
On 2017/05/01 14:53:38, Fan Yang wrote:
> I did not see the definitions (as you removed from quic_test_utils.cc) of
these
> functions?

Good point! I forgot to upload the .cc file :(

Done.

[Ryan Hamilton, 2017-05-01 16:46:38]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 16:47:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fan Yang, 2017-05-01 16:53:28]

On 2017/05/01 16:46:30, Ryan Hamilton wrote:
> Thanks!
> 
>
https://codereview.chromium.org/2848203002/diff/1/net/quic/platform/impl/quic...
> File net/quic/platform/impl/quic_test_impl.h (right):
> 
>
https://codereview.chromium.org/2848203002/diff/1/net/quic/platform/impl/quic...
> net/quic/platform/impl/quic_test_impl.h:15: QuicFlagSaver();
> On 2017/05/01 14:53:38, Fan Yang wrote:
> > I did not see the definitions (as you removed from quic_test_utils.cc) of
> these
> > functions?
> 
> Good point! I forgot to upload the .cc file :(
> 
> Done.

lgtm

Thank you!

[Ryan Hamilton, 2017-05-01 17:22:38]

rch@chromium.org changed reviewers:
+ ckrasic@chromium.org

[Ryan Hamilton, 2017-05-01 17:22:38]

ckrasic: can you approve, since you're a committer?

[Buck, 2017-05-01 17:24:17]

lgtm

[Buck, 2017-05-01 17:24:20]

lgtm

[Ryan Hamilton, 2017-05-01 17:55:30]

Description was changed from

==========
Add a platform implementation of QuicTest and QuicTestWithParam
to serve as the base class for all QUIC tests.

This includes code to flip flags back to their default values.

Merge internal change: 154672109

BUG=
==========

to

==========
Add a platform implementation of QuicTest and QuicTestWithParam
to serve as the base class for all QUIC tests.

This includes code to flip flags back to their default values.

Merge internal change: 154732382

BUG=
==========

[Ryan Hamilton, 2017-05-01 17:55:38]

The CQ bit was unchecked by rch@chromium.org

[Ryan Hamilton, 2017-05-01 17:55:46]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2017-05-01 17:56:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 18:54:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493661346006610,
"parent_rev": "859478de176cb190f39398aba66157315e66fd17", "commit_rev":
"8458180a3b6315ff262f1bb7919519595eadcb0f"}

[commit-bot: I haz the power, 2017-05-01 18:54:14]

Description was changed from

==========
Add a platform implementation of QuicTest and QuicTestWithParam
to serve as the base class for all QUIC tests.

This includes code to flip flags back to their default values.

Merge internal change: 154732382

BUG=
==========

to

==========
Add a platform implementation of QuicTest and QuicTestWithParam
to serve as the base class for all QUIC tests.

This includes code to flip flags back to their default values.

Merge internal change: 154732382

BUG=

Review-Url: https://codereview.chromium.org/2848203002
Cr-Commit-Position: refs/heads/master@{#468373}
Committed:
https://chromium.googlesource.com/chromium/src/+/8458180a3b6315ff262f1bb79195...
==========

[commit-bot: I haz the power, 2017-05-01 18:54:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8458180a3b6315ff262f1bb79195...