Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: net/quic/core/quic_session_test.cc

Issue 2848203002: Add a platform implementation of QuicTest and QuicTestWithParam (Closed)
Patch Set: net/quic/platform/impl/quic_test_impl.cc Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_server_session_base_test.cc ('k') | net/quic/core/quic_simple_buffer_allocator_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_session_test.cc
diff --git a/net/quic/core/quic_session_test.cc b/net/quic/core/quic_session_test.cc
index 9da380c7f6b87c75c01be068a8bf7f82540c13ae..cf0879560ac9406dccdea89208db62cced7c40eb 100644
--- a/net/quic/core/quic_session_test.cc
+++ b/net/quic/core/quic_session_test.cc
@@ -21,6 +21,7 @@
#include "net/quic/platform/api/quic_ptr_util.h"
#include "net/quic/platform/api/quic_str_cat.h"
#include "net/quic/platform/api/quic_string_piece.h"
+#include "net/quic/platform/api/quic_test.h"
#include "net/quic/test_tools/quic_config_peer.h"
#include "net/quic/test_tools/quic_connection_peer.h"
#include "net/quic/test_tools/quic_flow_controller_peer.h"
@@ -31,9 +32,7 @@
#include "net/quic/test_tools/quic_test_utils.h"
#include "net/spdy/core/spdy_framer.h"
#include "net/test/gtest_util.h"
-#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gmock_mutant.h"
-#include "testing/gtest/include/gtest/gtest.h"
using std::string;
using testing::CreateFunctor;
@@ -223,7 +222,7 @@ class TestSession : public QuicSpdySession {
bool writev_consumes_all_data_;
};
-class QuicSessionTestBase : public ::testing::TestWithParam<QuicVersion> {
+class QuicSessionTestBase : public QuicTestWithParam<QuicVersion> {
protected:
explicit QuicSessionTestBase(Perspective perspective)
: connection_(
@@ -284,7 +283,6 @@ class QuicSessionTestBase : public ::testing::TestWithParam<QuicVersion> {
QuicVersion version() const { return connection_->version(); }
- QuicFlagSaver flags_; // Save/restore all QUIC flag values.
MockQuicConnectionHelper helper_;
MockAlarmFactory alarm_factory_;
StrictMock<MockQuicConnection>* connection_;
« no previous file with comments | « net/quic/core/quic_server_session_base_test.cc ('k') | net/quic/core/quic_simple_buffer_allocator_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698