Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1375)

Unified Diff: net/quic/platform/api/quic_hostname_utils_test.cc

Issue 2848203002: Add a platform implementation of QuicTest and QuicTestWithParam (Closed)
Patch Set: net/quic/platform/impl/quic_test_impl.cc Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/platform/api/quic_endian_test.cc ('k') | net/quic/platform/api/quic_lru_cache_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/platform/api/quic_hostname_utils_test.cc
diff --git a/net/quic/platform/api/quic_hostname_utils_test.cc b/net/quic/platform/api/quic_hostname_utils_test.cc
index 2c7e6c8e89a5016aff0bc0896075bf7fa41325c3..65bbcb1749133ea6fb4b828eeb698545aac87aa6 100644
--- a/net/quic/platform/api/quic_hostname_utils_test.cc
+++ b/net/quic/platform/api/quic_hostname_utils_test.cc
@@ -4,7 +4,7 @@
#include "net/quic/platform/api/quic_hostname_utils.h"
-#include "testing/gtest/include/gtest/gtest.h"
+#include "net/quic/platform/api/quic_test.h"
using std::string;
@@ -12,7 +12,9 @@ namespace net {
namespace test {
namespace {
-TEST(QuicHostnameUtilsTest, IsValidSNI) {
+class QuicHostnameUtilsTest : public QuicTest {};
+
+TEST_F(QuicHostnameUtilsTest, IsValidSNI) {
// IP as SNI.
EXPECT_FALSE(QuicHostnameUtils::IsValidSNI("192.168.0.1"));
// SNI without any dot.
@@ -27,7 +29,7 @@ TEST(QuicHostnameUtilsTest, IsValidSNI) {
EXPECT_TRUE(QuicHostnameUtils::IsValidSNI("test.google.com"));
}
-TEST(QuicHostnameUtilsTest, NormalizeHostname) {
+TEST_F(QuicHostnameUtilsTest, NormalizeHostname) {
struct {
const char *input, *expected;
} tests[] = {
« no previous file with comments | « net/quic/platform/api/quic_endian_test.cc ('k') | net/quic/platform/api/quic_lru_cache_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698