Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: net/quic/core/quic_packet_creator_test.cc

Issue 2848203002: Add a platform implementation of QuicTest and QuicTestWithParam (Closed)
Patch Set: net/quic/platform/impl/quic_test_impl.cc Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_one_block_arena_test.cc ('k') | net/quic/core/quic_packet_generator_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_packet_creator_test.cc
diff --git a/net/quic/core/quic_packet_creator_test.cc b/net/quic/core/quic_packet_creator_test.cc
index 41a159379d2e203ffa5f21b761d1e9a347d5bf7f..6e7c87c6bcc68fb602c323dd6c163eda60ae976f 100644
--- a/net/quic/core/quic_packet_creator_test.cc
+++ b/net/quic/core/quic_packet_creator_test.cc
@@ -18,11 +18,10 @@
#include "net/quic/core/quic_utils.h"
#include "net/quic/platform/api/quic_socket_address.h"
#include "net/quic/platform/api/quic_string_piece.h"
+#include "net/quic/platform/api/quic_test.h"
#include "net/quic/test_tools/quic_framer_peer.h"
#include "net/quic/test_tools/quic_packet_creator_peer.h"
#include "net/quic/test_tools/quic_test_utils.h"
-#include "testing/gmock/include/gmock/gmock.h"
-#include "testing/gtest/include/gtest/gtest.h"
using std::string;
using testing::DoAll;
@@ -87,7 +86,7 @@ class MockDelegate : public QuicPacketCreator::DelegateInterface {
DISALLOW_COPY_AND_ASSIGN(MockDelegate);
};
-class QuicPacketCreatorTest : public ::testing::TestWithParam<TestParams> {
+class QuicPacketCreatorTest : public QuicTestWithParam<TestParams> {
public:
void ClearSerializedPacketForTests(SerializedPacket* serialized_packet) {
if (serialized_packet == nullptr) {
@@ -210,7 +209,6 @@ class QuicPacketCreatorTest : public ::testing::TestWithParam<TestParams> {
static const QuicStreamOffset kOffset = 1u;
- QuicFlagSaver flags_; // Save/restore all QUIC flag values.
char buffer_[kMaxPacketSize];
QuicFrames frames_;
QuicFramer server_framer_;
« no previous file with comments | « net/quic/core/quic_one_block_arena_test.cc ('k') | net/quic/core/quic_packet_generator_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698