Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: net/quic/platform/api/quic_reference_counted_test.cc

Issue 2848203002: Add a platform implementation of QuicTest and QuicTestWithParam (Closed)
Patch Set: net/quic/platform/impl/quic_test_impl.cc Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/platform/api/quic_lru_cache_test.cc ('k') | net/quic/platform/api/quic_str_cat_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/platform/api/quic_reference_counted_test.cc
diff --git a/net/quic/platform/api/quic_reference_counted_test.cc b/net/quic/platform/api/quic_reference_counted_test.cc
index 8f46094b6fed6b66fbc9fcb099359d83457fba86..d5e1f39cdec4eddc4b207052ab2cd8d0c64a0139 100644
--- a/net/quic/platform/api/quic_reference_counted_test.cc
+++ b/net/quic/platform/api/quic_reference_counted_test.cc
@@ -4,7 +4,7 @@
#include "net/quic/platform/api/quic_reference_counted.h"
-#include "testing/gtest/include/gtest/gtest.h"
+#include "net/quic/platform/api/quic_test.h"
namespace net {
namespace test {
@@ -33,14 +33,16 @@ class Derived : public Base {
~Derived() override {}
};
-TEST(QuicReferenceCountedTest, DefaultConstructor) {
+class QuicReferenceCountedTest : public QuicTest {};
+
+TEST_F(QuicReferenceCountedTest, DefaultConstructor) {
QuicReferenceCountedPointer<Base> a;
EXPECT_EQ(nullptr, a);
EXPECT_EQ(nullptr, a.get());
EXPECT_FALSE(a);
}
-TEST(QuicReferenceCountedTest, ConstructFromRawPointer) {
+TEST_F(QuicReferenceCountedTest, ConstructFromRawPointer) {
bool destroyed = false;
{
QuicReferenceCountedPointer<Base> a(new Base(&destroyed));
@@ -49,7 +51,7 @@ TEST(QuicReferenceCountedTest, ConstructFromRawPointer) {
EXPECT_TRUE(destroyed);
}
-TEST(QuicReferenceCountedTest, RawPointerAssignment) {
+TEST_F(QuicReferenceCountedTest, RawPointerAssignment) {
bool destroyed = false;
{
QuicReferenceCountedPointer<Base> a;
@@ -60,7 +62,7 @@ TEST(QuicReferenceCountedTest, RawPointerAssignment) {
EXPECT_TRUE(destroyed);
}
-TEST(QuicReferenceCountedTest, PointerCopy) {
+TEST_F(QuicReferenceCountedTest, PointerCopy) {
bool destroyed = false;
{
QuicReferenceCountedPointer<Base> a(new Base(&destroyed));
@@ -74,7 +76,7 @@ TEST(QuicReferenceCountedTest, PointerCopy) {
EXPECT_TRUE(destroyed);
}
-TEST(QuicReferenceCountedTest, PointerCopyAssignment) {
+TEST_F(QuicReferenceCountedTest, PointerCopyAssignment) {
bool destroyed = false;
{
QuicReferenceCountedPointer<Base> a(new Base(&destroyed));
@@ -88,7 +90,7 @@ TEST(QuicReferenceCountedTest, PointerCopyAssignment) {
EXPECT_TRUE(destroyed);
}
-TEST(QuicReferenceCountedTest, PointerCopyFromOtherType) {
+TEST_F(QuicReferenceCountedTest, PointerCopyFromOtherType) {
bool destroyed = false;
{
QuicReferenceCountedPointer<Derived> a(new Derived(&destroyed));
@@ -102,7 +104,7 @@ TEST(QuicReferenceCountedTest, PointerCopyFromOtherType) {
EXPECT_TRUE(destroyed);
}
-TEST(QuicReferenceCountedTest, PointerCopyAssignmentFromOtherType) {
+TEST_F(QuicReferenceCountedTest, PointerCopyAssignmentFromOtherType) {
bool destroyed = false;
{
QuicReferenceCountedPointer<Derived> a(new Derived(&destroyed));
@@ -116,7 +118,7 @@ TEST(QuicReferenceCountedTest, PointerCopyAssignmentFromOtherType) {
EXPECT_TRUE(destroyed);
}
-TEST(QuicReferenceCountedTest, PointerMove) {
+TEST_F(QuicReferenceCountedTest, PointerMove) {
bool destroyed = false;
QuicReferenceCountedPointer<Base> a(new Derived(&destroyed));
EXPECT_FALSE(destroyed);
@@ -129,7 +131,7 @@ TEST(QuicReferenceCountedTest, PointerMove) {
EXPECT_TRUE(destroyed);
}
-TEST(QuicReferenceCountedTest, PointerMoveAssignment) {
+TEST_F(QuicReferenceCountedTest, PointerMoveAssignment) {
bool destroyed = false;
QuicReferenceCountedPointer<Base> a(new Derived(&destroyed));
EXPECT_FALSE(destroyed);
@@ -142,7 +144,7 @@ TEST(QuicReferenceCountedTest, PointerMoveAssignment) {
EXPECT_TRUE(destroyed);
}
-TEST(QuicReferenceCountedTest, PointerMoveFromOtherType) {
+TEST_F(QuicReferenceCountedTest, PointerMoveFromOtherType) {
bool destroyed = false;
QuicReferenceCountedPointer<Derived> a(new Derived(&destroyed));
EXPECT_FALSE(destroyed);
@@ -155,7 +157,7 @@ TEST(QuicReferenceCountedTest, PointerMoveFromOtherType) {
EXPECT_TRUE(destroyed);
}
-TEST(QuicReferenceCountedTest, PointerMoveAssignmentFromOtherType) {
+TEST_F(QuicReferenceCountedTest, PointerMoveAssignmentFromOtherType) {
bool destroyed = false;
QuicReferenceCountedPointer<Derived> a(new Derived(&destroyed));
EXPECT_FALSE(destroyed);
« no previous file with comments | « net/quic/platform/api/quic_lru_cache_test.cc ('k') | net/quic/platform/api/quic_str_cat_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698